feat: add property for indentation allowed chars

Author: Emilien Escalle

src/CssLint/Linter.php

@@ -207,7 +207,7 @@ protected function lintChar(string $sChar): ?bool
 
         if (is_bool($bLintNestedSelectorChar = $this->lintNestedSelectorChar($sChar))) {
             $this->setPreviousChar($sChar);
-            return $bLintPropertyContentChar;
+            return $bLintNestedSelectorChar;
         }
 
         $this->addError('Unexpected char ' . json_encode($sChar));
@@ -251,9 +251,11 @@ protected function lintSelectorChar(string $sChar): ?bool
     {
         // Selector must start by #.a-zA-Z
         if ($this->assertContext(null)) {
-            if ($sChar === ' ') {
+
+            if ($this->getCssLintProperties()->isAllowedIndentationChar($sChar)) {
                 return true;
             }
+
             if (preg_match('/[@#.a-zA-Z\[\*-:]+/', $sChar)) {
                 $this->setContext(self::CONTEXT_SELECTOR);
                 $this->addContextContent($sChar);
@@ -347,9 +349,14 @@ protected function lintSelectorContentChar(string $sChar): ?bool
         if (!$this->assertContext(self::CONTEXT_SELECTOR_CONTENT)) {
             return null;
         }
-        if ($sChar === ' ') {
+
+        $sContextContent = $this->getContextContent();
+        if ((!$sContextContent || $sContextContent === '{') &&
+            $this->getCssLintProperties()->isAllowedIndentationChar($sChar)
+        ) {
             return true;
         }
+
         if ($sChar === '}') {
             if ($this->isNestedSelector()) {
                 $this->resetContext();

src/CssLint/Properties.php

@@ -460,6 +460,8 @@ class Properties
         'text-size-adjust' => '',
     ];
 
+    protected static $allowedIndentationChars = [' '];
+
     /**
      * @param string $sProperty
      * @return boolean
@@ -486,4 +488,19 @@ public static function propertyExists(string $sProperty): bool
         }
         return false;
     }
+
+    public static function getAllowedIndentationChars(): array
+    {
+        return static::$allowedIndentationChars;
+    }
+
+    public static function setAllowedIndentationChars(array $aAllowedIndentationChars)
+    {
+        static::$allowedIndentationChars = $aAllowedIndentationChars;
+    }
+
+    public static function isAllowedIndentationChar($sChar): bool
+    {
+        return in_array($sChar, static::$allowedIndentationChars, true);
+    }
 }

tests/TestSuite/LinterTest.php

@@ -41,7 +41,7 @@ public function testLintValidString()
   .button.arrow-only::after {
     top: -0.1em;
     float: none;
-    margin-left: 0; }'));
+    margin-left: 0; }'), print_r($this->linter->getErrors(), true));
     }
 
     public function testLintNotValidString()
@@ -57,6 +57,16 @@ public function testLintNotValidString()
         ], $this->linter->getErrors());
     }
 
+    public function testLintValidStringContainingTabs()
+    {
+        $this->linter->getCssLintProperties()->setAllowedIndentationChars(["\t"]);
+        $this->assertTrue($this->linter->lintString("\t\t" . '.button.dropdown::after {
+' . "\t\t" . 'display: block;
+' . "\t\t" . '}'), print_r($this->linter->getErrors(), true));
+
+        $this->linter->getCssLintProperties()->setAllowedIndentationChars([' ']);
+    }
+
     public function testLintStringWithUnterminatedContext()
     {
         $this->assertFalse($this->linter->lintString('* {'));