'source' and 'target' descriptors confuse users of this module

[billglick]

Consider renaming these.

Here are some clearer alternatives that reflect the SSH roles more intuitively:

source - this host initiates SSH connections

• rename to ssh_client or initiator

target - this host accepts SSH connections

• rename to ssh_server or acceptor

Other naming ideas:

• hostbased_initiator / hostbased_acceptor
• ssh_trusted_host / ssh_trusting_host (if you want to emphasize trust direction)
• ssh_auth_sender / ssh_auth_receiver

While these changes may never happen in this Puppet profile, keep these ideas in mind if/when we develop a similar Ansible role for the same functionality.

[inwho]

I think one thing that tripped me up was source::host_match_pattern:
On ICCP, target::sshd_match_nodelist: is provided through data/common.yaml and absent in the role/cluster hieras, and so when I'm editing those files and I saw the entry for source::host_match_pattern: by itself, my initial interpretation for this parameter was "target match patterns".

I am still a bit unsure if I correctly understand how this module works. Suppose host A is the source / initiator and host B is the target/acceptor. Are these parameters defined on both host A and B? Do they look the same on both?

[billglick]

It gets confusing because any specific host can be 1) either, 2) both, or 3) neither of these profiles:

• source/initiator
• target/acceptor

And just because we set default data for these profiles in some level of heira, that doesn't mean a host at that level includes the profile for either source or target. e.g. the target variables assigned in data/common.yaml are just generic values if the host's role includes the target profile.