From f3cf623aef0b8a67e49908b46f1c72a41953635e Mon Sep 17 00:00:00 2001 From: jun Date: Fri, 13 Mar 2026 08:55:10 +0900 Subject: [PATCH] Fix incorrect error message in size validation --- .../fixturemonkey/builder/DefaultArbitraryBuilder.java | 2 +- .../java/com/navercorp/fixturemonkey/customizer/InnerSpec.java | 2 +- .../fixturemonkey/adapter/ValueProjectionCustomizationTest.java | 2 +- .../com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/builder/DefaultArbitraryBuilder.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/builder/DefaultArbitraryBuilder.java index 2a39516f12..225cc76bff 100644 --- a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/builder/DefaultArbitraryBuilder.java +++ b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/builder/DefaultArbitraryBuilder.java @@ -245,7 +245,7 @@ public ArbitraryBuilder size(String expression, int minSize, int maxSize) { @Override public ArbitraryBuilder size(PropertySelector propertySelector, int minSize, int maxSize) { if (minSize > maxSize) { - throw new IllegalArgumentException("should be min > max, min : " + minSize + " max : " + maxSize); + throw new IllegalArgumentException("should be min <= max, min : " + minSize + " max : " + maxSize); } List nextNodePredicates = toMonkeyExpression(propertySelector).toNextNodePredicate(); diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/customizer/InnerSpec.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/customizer/InnerSpec.java index 1699b01fb5..5255a73f21 100644 --- a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/customizer/InnerSpec.java +++ b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/customizer/InnerSpec.java @@ -114,7 +114,7 @@ public InnerSpec inner(InnerSpec innerSpec) { */ public InnerSpec size(int minSize, int maxSize) { if (minSize > maxSize) { - throw new IllegalArgumentException("should be min > max, min : " + minSize + " max : " + maxSize); + throw new IllegalArgumentException("should be min <= max, min : " + minSize + " max : " + maxSize); } this.state.setContainerInfoSnapshot( diff --git a/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/adapter/ValueProjectionCustomizationTest.java b/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/adapter/ValueProjectionCustomizationTest.java index 1ab9455865..c9e86ba289 100644 --- a/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/adapter/ValueProjectionCustomizationTest.java +++ b/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/adapter/ValueProjectionCustomizationTest.java @@ -1058,7 +1058,7 @@ void sizeMinMax() { void sizeMinIsBiggerThanMax() { thenThrownBy(() -> SUT.giveMeBuilder(StringListHolder.class).size("values", 5, 1).sample()) .isExactlyInstanceOf(IllegalArgumentException.class) - .hasMessageContaining("should be min > max"); + .hasMessageContaining("should be min <= max"); } @Property diff --git a/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java b/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java index ba9ddf7484..7418182d3d 100644 --- a/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java +++ b/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java @@ -388,7 +388,7 @@ void sizeMinIsBiggerThanMax() { // when thenThrownBy(() -> SUT.giveMeBuilder(ComplexObject.class).size("strList", 5, 1).sample()) .isExactlyInstanceOf(IllegalArgumentException.class) - .hasMessageContaining("should be min > max"); + .hasMessageContaining("should be min <= max"); } @Example