Fix generated source image links#243
Open
sunilkumarvalmiki wants to merge 1 commit into
Open
Conversation
Owner
|
please fix the conflicts, thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
../media/...so they resolve fromwiki/sources/*.mdin external Markdown editors.wiki/media/...for in-app preview loading.Evidence
Before: #170 reports that generated source Markdown used
media/...links, which do not resolve from files underwiki/sources/when opened outside the app.After: embedded-image sections in source summaries point to
../media/..., while the app still resolves bothmedia/...and../media/...to the same media files.Tests
npm run test:mocks -- src/lib/extract-source-images.test.ts src/lib/markdown-image-resolver.test.ts src/lib/raw-source-resolver.test.tsnpm run test:mocksnpm run typechecknpm run buildgit diff --checkCloses #170