scanner: remove redundant section-config loader partial indirections

Author: GitHub Copilot

src/prism/scanner.py

@@ -861,57 +861,17 @@ def _load_section_display_titles() -> dict[str, str]:
 )
 
 
-_load_fail_on_unconstrained_dynamic_includes_from_section_config = partial(
-    _load_fail_on_unconstrained_dynamic_includes,
-    config_filenames=SECTION_CONFIG_FILENAMES,
-    default_filename=SECTION_CONFIG_FILENAME,
-)
-
-
-_load_fail_on_yaml_like_task_annotations_from_section_config = partial(
-    _load_fail_on_yaml_like_task_annotations,
-    config_filenames=SECTION_CONFIG_FILENAMES,
-    default_filename=SECTION_CONFIG_FILENAME,
-)
-
-
-_load_ignore_unresolved_internal_underscore_references_from_section_config = partial(
-    _load_ignore_unresolved_internal_underscore_references,
-    config_filenames=SECTION_CONFIG_FILENAMES,
-    default_filename=SECTION_CONFIG_FILENAME,
-)
-
-
-_load_non_authoritative_test_evidence_max_file_bytes_from_section_config = partial(
-    _load_non_authoritative_test_evidence_max_file_bytes,
-    config_filenames=SECTION_CONFIG_FILENAMES,
-    default_filename=SECTION_CONFIG_FILENAME,
-)
-
-
-_load_non_authoritative_test_evidence_max_files_scanned_from_section_config = partial(
-    _load_non_authoritative_test_evidence_max_files_scanned,
-    config_filenames=SECTION_CONFIG_FILENAMES,
-    default_filename=SECTION_CONFIG_FILENAME,
-)
-
-
-_load_non_authoritative_test_evidence_max_total_bytes_from_section_config = partial(
-    _load_non_authoritative_test_evidence_max_total_bytes,
-    config_filenames=SECTION_CONFIG_FILENAMES,
-    default_filename=SECTION_CONFIG_FILENAME,
-)
-
-
 def load_fail_on_unconstrained_dynamic_includes(
     role_path: str,
     config_path: str | None = None,
     default: bool = False,
 ) -> bool:
-    return _load_fail_on_unconstrained_dynamic_includes_from_section_config(
+    return _load_fail_on_unconstrained_dynamic_includes(
         role_path,
         config_path=config_path,
         default=default,
+        config_filenames=SECTION_CONFIG_FILENAMES,
+        default_filename=SECTION_CONFIG_FILENAME,
     )
 
 
@@ -920,10 +880,12 @@ def load_fail_on_yaml_like_task_annotations(
     config_path: str | None = None,
     default: bool = False,
 ) -> bool:
-    return _load_fail_on_yaml_like_task_annotations_from_section_config(
+    return _load_fail_on_yaml_like_task_annotations(
         role_path,
         config_path=config_path,
         default=default,
+        config_filenames=SECTION_CONFIG_FILENAMES,
+        default_filename=SECTION_CONFIG_FILENAME,
     )
 
 
@@ -932,10 +894,12 @@ def load_ignore_unresolved_internal_underscore_references(
     config_path: str | None = None,
     default: bool = True,
 ) -> bool:
-    return _load_ignore_unresolved_internal_underscore_references_from_section_config(
+    return _load_ignore_unresolved_internal_underscore_references(
         role_path,
         config_path=config_path,
         default=default,
+        config_filenames=SECTION_CONFIG_FILENAMES,
+        default_filename=SECTION_CONFIG_FILENAME,
     )
 
 
@@ -944,10 +908,12 @@ def load_non_authoritative_test_evidence_max_file_bytes(
     config_path: str | None = None,
     default: int = NON_AUTHORITATIVE_TEST_EVIDENCE_MAX_FILE_BYTES,
 ) -> int:
-    return _load_non_authoritative_test_evidence_max_file_bytes_from_section_config(
+    return _load_non_authoritative_test_evidence_max_file_bytes(
         role_path,
         config_path=config_path,
         default=default,
+        config_filenames=SECTION_CONFIG_FILENAMES,
+        default_filename=SECTION_CONFIG_FILENAME,
     )
 
 
@@ -956,10 +922,12 @@ def load_non_authoritative_test_evidence_max_files_scanned(
     config_path: str | None = None,
     default: int = NON_AUTHORITATIVE_TEST_EVIDENCE_MAX_FILES_SCANNED,
 ) -> int:
-    return _load_non_authoritative_test_evidence_max_files_scanned_from_section_config(
+    return _load_non_authoritative_test_evidence_max_files_scanned(
         role_path,
         config_path=config_path,
         default=default,
+        config_filenames=SECTION_CONFIG_FILENAMES,
+        default_filename=SECTION_CONFIG_FILENAME,
     )
 
 
@@ -968,10 +936,12 @@ def load_non_authoritative_test_evidence_max_total_bytes(
     config_path: str | None = None,
     default: int = NON_AUTHORITATIVE_TEST_EVIDENCE_MAX_TOTAL_BYTES,
 ) -> int:
-    return _load_non_authoritative_test_evidence_max_total_bytes_from_section_config(
+    return _load_non_authoritative_test_evidence_max_total_bytes(
         role_path,
         config_path=config_path,
         default=default,
+        config_filenames=SECTION_CONFIG_FILENAMES,
+        default_filename=SECTION_CONFIG_FILENAME,
     )
 
 
@@ -1161,16 +1131,14 @@ def _apply_readme_section_config(
 _apply_unconstrained_dynamic_include_policy = partial(
     _scan_runtime.apply_unconstrained_dynamic_include_policy,
     load_fail_on_unconstrained_dynamic_includes=(
-        _load_fail_on_unconstrained_dynamic_includes_from_section_config
+        load_fail_on_unconstrained_dynamic_includes
     ),
 )
 
 
 _apply_yaml_like_task_annotation_policy = partial(
     _scan_runtime.apply_yaml_like_task_annotation_policy,
-    load_fail_on_yaml_like_task_annotations=(
-        _load_fail_on_yaml_like_task_annotations_from_section_config
-    ),
+    load_fail_on_yaml_like_task_annotations=(load_fail_on_yaml_like_task_annotations),
 )
 
 
@@ -1217,16 +1185,16 @@ def _apply_readme_section_config(
     scan_context_builder_cls=ScanContextBuilder,
     collect_scan_base_context=_collect_scan_base_context,
     load_ignore_unresolved_internal_underscore_references=(
-        _load_ignore_unresolved_internal_underscore_references_from_section_config
+        load_ignore_unresolved_internal_underscore_references
     ),
     load_non_authoritative_test_evidence_max_file_bytes=(
-        _load_non_authoritative_test_evidence_max_file_bytes_from_section_config
+        load_non_authoritative_test_evidence_max_file_bytes
     ),
     load_non_authoritative_test_evidence_max_files_scanned=(
-        _load_non_authoritative_test_evidence_max_files_scanned_from_section_config
+        load_non_authoritative_test_evidence_max_files_scanned
     ),
     load_non_authoritative_test_evidence_max_total_bytes=(
-        _load_non_authoritative_test_evidence_max_total_bytes_from_section_config
+        load_non_authoritative_test_evidence_max_total_bytes
     ),
     enrich_scan_context_with_insights=_enrich_scan_context_with_insights,
     finalize_scan_context_payload=_finalize_scan_context_payload,