avoid changing literalExpression for performance reason

Signed-off-by: Murphy <mofei@starrocks.com>

Author: murphyatwork

fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java

@@ -6243,8 +6243,9 @@ public ParseNode visitJoinRelation(com.starrocks.sql.parser.StarRocksParser.Join
             if (context.bracketHint().primaryExpression() != null) {
                 joinRelation.setSkewColumn((Expr) visit(context.bracketHint().primaryExpression()));
             }
-            if (context.bracketHint().literalExpressionList() != null) {
-                joinRelation.setSkewValues(visit(context.bracketHint().literalExpressionList().literalExpression(),
+            if (context.bracketHint().generalLiteralExpressionList() != null) {
+                joinRelation.setSkewValues(
+                        visit(context.bracketHint().generalLiteralExpressionList().generalLiteralExpression(),
                         Expr.class));
             }
         }
@@ -8032,27 +8033,40 @@ public ParseNode visitBooleanLiteral(com.starrocks.sql.parser.StarRocksParser.Bo
 
     @Override
     public ParseNode visitNumericLiteral(com.starrocks.sql.parser.StarRocksParser.NumericLiteralContext context) {
-        ParseNode node = visit(context.number());
-        if (context.MINUS_SYMBOL() != null) {
-            if (node instanceof IntLiteral) {
-                return new IntLiteral(-((IntLiteral) node).getLongValue(), node.getPos());
-            } else if (node instanceof LargeIntLiteral) {
-                BigInteger val = ((LargeIntLiteral) node).getValue();
-                val = val.negate();
-                if (val.compareTo(BigInteger.valueOf(Long.MIN_VALUE)) >= 0 &&
-                        val.compareTo(BigInteger.valueOf(Long.MAX_VALUE)) <= 0) {
-                    return new IntLiteral(val.longValue(), node.getPos());
+        return visit(context.number());
+    }
+
+    @Override
+    public ParseNode visitGeneralLiteralExpression(
+            com.starrocks.sql.parser.StarRocksParser.GeneralLiteralExpressionContext context) {
+        if (context.literalExpression() != null) {
+            return visit(context.literalExpression());
+        } else {
+            ParseNode node = visit(context.number());
+            if (context.MINUS_SYMBOL() != null) {
+                if (node instanceof IntLiteral) {
+                    return new IntLiteral(-((IntLiteral) node).getLongValue(), node.getPos());
+                } else if (node instanceof LargeIntLiteral) {
+                    BigInteger val = ((LargeIntLiteral) node).getValue();
+                    val = val.negate();
+                    if (val.compareTo(BigInteger.valueOf(Long.MIN_VALUE)) >= 0 &&
+                            val.compareTo(BigInteger.valueOf(Long.MAX_VALUE)) <= 0) {
+                        return new IntLiteral(val.longValue(), node.getPos());
+                    }
+                    return new LargeIntLiteral(val.toString(), node.getPos());
+                } else if (node instanceof DecimalLiteral) {
+                    BigDecimal val = ((DecimalLiteral) node).getValue();
+                    return new DecimalLiteral(val.negate(), node.getPos());
+                } else if (node instanceof FloatLiteral) {
+                    double val = ((FloatLiteral) node).getDoubleValue();
+                    return new FloatLiteral(-val, node.getPos());
+                } else {
+                    throw new ParsingException(PARSER_ERROR_MSG.invalidNumFormat(context.getText()), node.getPos());
                 }
-                return new LargeIntLiteral(val.toString(), node.getPos());
-            } else if (node instanceof DecimalLiteral) {
-                BigDecimal val = ((DecimalLiteral) node).getValue();
-                return new DecimalLiteral(val.negate(), node.getPos());
-            } else if (node instanceof FloatLiteral) {
-                double val = ((FloatLiteral) node).getDoubleValue();
-                return new FloatLiteral(-val, node.getPos());
+            } else {
+                return node;
             }
         }
-        return node;
     }
 
     @Override

fe/fe-core/src/test/java/com/starrocks/sql/parser/InPredicateParserBench.java

@@ -61,13 +61,13 @@ public void setup() {
         sql = generateSQL();
     }
 
-    @Param({"5000", "50000"})
+    @Param({"5000", "50000", "200000"})
     public int count;
 
-    @Param({"true", "false"})
+    @Param({"false", "true"})
     public boolean positive;
 
-    public final int baseNumber = 1_000_000;
+    public final int baseNumber = 10_000_000;
 
     @Benchmark
     public void parseInPredicate() {

fe/fe-core/src/test/java/com/starrocks/sql/parser/ParserTest.java

@@ -707,11 +707,7 @@ void testSkewHintWithNegativeValues() {
         };
         SessionVariable sessionVariable = new SessionVariable();
         for (String sql : sqls) {
-            try {
-                SqlParser.parse(sql, sessionVariable);
-            } catch (Exception e) {
-                fail("sql should parse successfully: " + sql + ", error: " + e.getMessage());
-            }
+            SqlParser.parse(sql, sessionVariable);
         }
     }
 

fe/fe-grammar/src/main/antlr/com/starrocks/grammar/StarRocks.g4

@@ -2497,7 +2497,7 @@ outerAndSemiJoinType
 
 bracketHint
     : '[' identifier (',' identifier)* ']'
-    | '[' identifier '|' primaryExpression literalExpressionList']'
+    | '[' identifier '|' primaryExpression generalLiteralExpressionList']'
     ;
 
 hintMap
@@ -2678,7 +2678,7 @@ primaryExpression
     ;
 
 literalExpression
-    : MINUS_SYMBOL? number                                                                #numericLiteral
+    : number                                                                              #numericLiteral
     | NULL                                                                                #nullLiteral
     | booleanValue                                                                        #booleanLiteral
     | (DATE | DATETIME) string                                                            #dateLiteral
@@ -2689,6 +2689,12 @@ literalExpression
     | PARAMETER                                                                           #Parameter
     ;
 
+// can represents negative number long with other literal expression
+generalLiteralExpression
+    : literalExpression
+    | MINUS_SYMBOL number
+    ;
+
 functionCall
     : EXTRACT '(' identifier FROM valueExpression ')'                                     #extract
     | GROUPING '(' (expression (',' expression)*)? ')'                                    #groupingOperation
@@ -2900,6 +2906,10 @@ literalExpressionList
     : '(' literalExpression (',' literalExpression)* ')'
     ;
 
+generalLiteralExpressionList
+    : '(' generalLiteralExpression (',' generalLiteralExpression)* ')'
+    ;
+
 rangePartitionDesc
     : singleRangePartition
     | multiRangePartition