Merge pull request #3 from multiagentcoordinationprotocol/fix-correctness-bugs

 v0.4.0: Fix correctness bugs, add lossless reconnect, outbound track…

Author: ajit-zer07

drizzle/0006_capabilities_and_stream.sql

@@ -0,0 +1,5 @@
+-- P1.3: Add capabilities, stream cursor, and stream timestamps to runtime_sessions
+ALTER TABLE "runtime_sessions" ADD COLUMN "capabilities" JSONB NOT NULL DEFAULT '{}';
+ALTER TABLE "runtime_sessions" ADD COLUMN "last_stream_cursor" INTEGER;
+ALTER TABLE "runtime_sessions" ADD COLUMN "stream_connected_at" TIMESTAMP WITH TIME ZONE;
+ALTER TABLE "runtime_sessions" ADD COLUMN "stream_disconnected_at" TIMESTAMP WITH TIME ZONE;

drizzle/0007_canonical_schema_version.sql

@@ -0,0 +1,2 @@
+-- P1.4: Add schema_version to canonical events
+ALTER TABLE "run_events_canonical" ADD COLUMN "schema_version" INTEGER NOT NULL DEFAULT 3;

drizzle/0008_webhook_active_boolean.sql

@@ -0,0 +1,3 @@
+-- P1.5: Fix webhook active column from integer to boolean
+ALTER TABLE "webhooks" ALTER COLUMN "active" TYPE BOOLEAN USING (active = 1);
+ALTER TABLE "webhooks" ALTER COLUMN "active" SET DEFAULT true;

drizzle/0009_outbound_messages.sql

@@ -0,0 +1,21 @@
+-- P2.2: Outbound message tracking table
+CREATE TABLE "run_outbound_messages" (
+  "id" UUID PRIMARY KEY,
+  "run_id" UUID NOT NULL REFERENCES "runs"("id") ON DELETE CASCADE,
+  "runtime_session_id" VARCHAR(255) NOT NULL,
+  "message_id" VARCHAR(255) NOT NULL,
+  "message_type" VARCHAR(128) NOT NULL,
+  "category" VARCHAR(32) NOT NULL,
+  "sender" VARCHAR(255) NOT NULL,
+  "recipients" JSONB NOT NULL DEFAULT '[]',
+  "status" VARCHAR(32) NOT NULL DEFAULT 'queued',
+  "payload_descriptor" JSONB NOT NULL DEFAULT '{}',
+  "ack" JSONB,
+  "error_message" TEXT,
+  "created_at" TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(),
+  "accepted_at" TIMESTAMP WITH TIME ZONE,
+  "updated_at" TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now()
+);
+CREATE UNIQUE INDEX ON "run_outbound_messages" ("message_id");
+CREATE INDEX ON "run_outbound_messages" ("run_id");
+CREATE INDEX ON "run_outbound_messages" ("status");

drizzle/0010_webhook_deliveries.sql

@@ -0,0 +1,18 @@
+-- P4.2: Durable webhook delivery tracking
+CREATE TABLE "webhook_deliveries" (
+  "id" UUID PRIMARY KEY,
+  "webhook_id" UUID NOT NULL REFERENCES "webhooks"("id") ON DELETE CASCADE,
+  "event" VARCHAR(128) NOT NULL,
+  "run_id" UUID NOT NULL,
+  "payload" JSONB NOT NULL,
+  "status" VARCHAR(32) NOT NULL DEFAULT 'pending',
+  "attempts" INTEGER NOT NULL DEFAULT 0,
+  "last_attempt_at" TIMESTAMP WITH TIME ZONE,
+  "response_status" INTEGER,
+  "error_message" TEXT,
+  "created_at" TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(),
+  "delivered_at" TIMESTAMP WITH TIME ZONE
+);
+CREATE INDEX ON "webhook_deliveries" ("webhook_id");
+CREATE INDEX ON "webhook_deliveries" ("status");
+CREATE INDEX ON "webhook_deliveries" ("run_id");

package-lock.json

@@ -32,6 +32,7 @@ import { EventRepository } from './storage/event.repository';
 import { ArtifactRepository } from './storage/artifact.repository';
 import { MetricsRepository } from './storage/metrics.repository';
 import { ProjectionRepository } from './storage/projection.repository';
+import { OutboundMessageRepository } from './storage/outbound-message.repository';
 import { RunRepository } from './storage/run.repository';
 import { RuntimeSessionRepository } from './storage/runtime-session.repository';
 import { InstrumentationService } from './telemetry/instrumentation.service';
@@ -42,6 +43,7 @@ import { RunManagerService } from './runs/run-manager.service';
 import { RunRecoveryService } from './runs/run-recovery.service';
 import { StreamConsumerService } from './runs/stream-consumer.service';
 import { WebhookController } from './controllers/webhook.controller';
+import { WebhookDeliveryRepository } from './webhooks/webhook-delivery.repository';
 import { WebhookRepository } from './webhooks/webhook.repository';
 import { WebhookService } from './webhooks/webhook.service';
 
@@ -68,6 +70,7 @@ import { WebhookService } from './webhooks/webhook.service';
     ProjectionRepository,
     ArtifactRepository,
     MetricsRepository,
+    OutboundMessageRepository,
     StreamHubService,
     EventNormalizerService,
     ProjectionService,
@@ -82,6 +85,7 @@ import { WebhookService } from './webhooks/webhook.service';
     RunRecoveryService,
     RunInsightsService,
     WebhookRepository,
+    WebhookDeliveryRepository,
     WebhookService
   ]
 })

src/app.module.ts

@@ -202,6 +202,13 @@ describe('AppConfigService', () => {
     });
   });
 
+  describe('clientVersion', () => {
+    it('should read version from package.json', () => {
+      const config = new AppConfigService();
+      expect(config.clientVersion).toBe('0.3.0');
+    });
+  });
+
   describe('readNumber edge cases', () => {
     it('should handle a valid number string for STREAM_BACKOFF_BASE_MS', () => {
       process.env.STREAM_BACKOFF_BASE_MS = '500';

src/config/app-config.service.spec.ts

@@ -26,6 +26,16 @@ export class AppConfigService implements OnModuleInit {
   readonly nodeEnv = process.env.NODE_ENV ?? 'development';
   readonly isDevelopment = this.nodeEnv === 'development';
 
+  /** Read from package.json at startup */
+  readonly clientVersion: string = (() => {
+    try {
+      // eslint-disable-next-line @typescript-eslint/no-require-imports
+      return require('../../package.json').version as string;
+    } catch {
+      return '0.0.0';
+    }
+  })();
+
   readonly port = readNumber('PORT', 3001);
   readonly host = process.env.HOST ?? '0.0.0.0';
   readonly corsOrigin = process.env.CORS_ORIGIN ?? 'http://localhost:3000';
@@ -68,6 +78,9 @@ export class AppConfigService implements OnModuleInit {
   readonly dbPoolIdleTimeout = readNumber('DB_POOL_IDLE_TIMEOUT', 30000);
   readonly dbPoolConnectionTimeout = readNumber('DB_POOL_CONNECTION_TIMEOUT', 5000);
 
+  readonly streamHubStrategy = process.env.STREAM_HUB_STRATEGY ?? 'memory';
+  readonly redisUrl = process.env.REDIS_URL ?? '';
+
   readonly logLevel = process.env.LOG_LEVEL ?? 'info';
   readonly otelEnabled = readBoolean('OTEL_ENABLED', false);
   readonly otelServiceName = process.env.OTEL_SERVICE_NAME ?? 'macp-control-plane';

src/config/app-config.service.ts

@@ -236,6 +236,13 @@ export interface ProgressProjection {
   }>;
 }
 
+export interface OutboundMessageSummary {
+  total: number;
+  queued: number;
+  accepted: number;
+  rejected: number;
+}
+
 export interface RunStateProjection {
   run: RunSummaryProjection;
   participants: ParticipantProjection[];
@@ -245,6 +252,7 @@ export interface RunStateProjection {
   progress: ProgressProjection;
   timeline: TimelineProjection;
   trace: TraceSummary;
+  outboundMessages: OutboundMessageSummary;
 }
 
 export interface ReplayRequest {