fix: promote scroll containers to their own composite layers.#56
Open
sortedcord wants to merge 1 commit into
Open
fix: promote scroll containers to their own composite layers.#56sortedcord wants to merge 1 commit into
sortedcord wants to merge 1 commit into
Conversation
Contributor
Author
|
I've figured out a few other areas where we can potentially gain performance like:
If you want I can include those changes as well in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #54
I've applied
will-change: transformto the scroll containers intiling-area.tsxandkanban-area.tsxso it's explicitly instructing the browser to promote these elements to their own GPU compositor layers before interaction happens. This ensures scrolling runs entirely on the compositor thread and prevents expensive re-rasterization during UI navigation. And sure enough nodepad scrolls at 60 fps even on low end devices:While this might not be very visible on systems made after 2020 or something it would however cause a decrease in cpu spike while using nodepad when scrolling with lots of nodes.
(As expected, barely any frames missing vsync deadlines)