Skip to content

Latest commit

 

History

History
187 lines (130 loc) · 7.21 KB

CONTRIBUTING.md

File metadata and controls

187 lines (130 loc) · 7.21 KB

Contributing code

GitHub contributors

We gladly accept contributions via GitHub pull requests!

You must complete the Contributor License Agreement. You can do this online, and it only takes a minute. If you've never submitted code before, you must add your (or your organization's) name and contact info to the AUTHORS file.

Development prep

  1. If you haven't already, follow the instructions to generate a new SSH key and connect to Github with SSH
  2. Follow the instructions to fork the DevTools repo to your own Github account, and clone using SSH
  3. Make sure to configure Git to keep your fork in sync with the main DevTools repo
  4. Finally, update to the newest version of the package with cd packages/devtools_app and flutter pub upgrade

From a separate terminal, start running a flutter app to connect to DevTools:

  • git clone https://github.com/flutter/gallery.git (this is an existing application with many examples of Flutter widgets)
  • cd gallery
  • ensure the iOS Simulator is open (or a physical device is connected)
  • flutter run

Workflow for making changes

  • Create a branch from your cloned repo: git checkout -b myBranch
  • Commit work to your branch: git commit -m “description”
  • Push to your branch: git push origin myBranch
  • Navigate to the Pull Requests tab in the main DevTools repo. You should see a popup to create a pull request from your local branch to DevTools master. Create a pull request.

Keeping your fork in-sync

  • Fetch branches/commits from the upstream DevTools: git fetch upstream
  • From your local branch, merge in the upstream master branch: git merge upstream/master

Development

To run DevTools as a Flutter web app, follow these steps.

First, perform one-time setup:

  • flutter config --enable-web

Now you can run the app at any time with the flutter command.

From the packages/devtools_app directory:

  • flutter run -d chrome

To test release performance:

  • flutter run -d web-server --release --dart-define=FLUTTER_WEB_USE_SKIA=true

You can also use -d headless-server, which will start a headless server that serves the HTML files for the DevTools Flutter app.

Development (DevTools server + DevTools Flutter web app)

To develop with a workflow that exercises the DevTools server <==> DevTools client connection, change to the packages/devtools directory, and run:

flutter pub get
dart bin/devtools.dart --debug

That will:

  • start the devtools server
  • start an instance of flutter run -d web-server from the packages/devtools_app directory
  • proxy all web traffic the devtools server doesn't handle directly to the flutter run development web server

You can then open a browser at the regular DevTools server URL (typically http://127.0.0.1:9100). When you make changes on disk, you can hit r in your command-line to rebuild the app, and refresh in your browser to see the changes. Hit q in the command line to terminate both the flutter run instance and the devtools server instance.

Desktop Embedder

You can also try running the app in the Flutter desktop embedder on linux or macos.

NOTE: The Linux desktop version only works with the master branch of Flutter (and sometimes this is true for MacOS as well). Syncing to a the master branch of Flutter may fail with a runner version error. If this occurs run flutter create . from devtools/packages/devtools_app, re-generates files in the linux and macos directories.

Depending on your OS, set up like this:

  • flutter config --enable-macos-desktop
  • flutter config --enable-linux-desktop

Now you can run with either of the following:

  • flutter run -d macos
  • flutter run -d linux

Where to put Flutter code

We also roll DevTools' code into a bazel build system, where we need to run only the non-flutter code from the app. To facilitate this, please keep code that imports package:flutter under a directory named 'flutter'.

For example, lib/src/flutter, lib/src/inspector/flutter, or test/flutter are all acceptable locations to put new Flutter code.

When we are ready to turn down the dart:html web version of the app, we will delete all code that isn't inside of or imported by the flutter code.

Developing with VS Code

DevTools Web

If you're using VS Code to work on DevTools you can run DevTools from the editor using the VS Code tasks without having to run in a terminal window:

  • Open the root of the repository in VS Code
  • Press F5

This will serve the application in the background and launch Google Chrome. Subsequent launches will just re-launch the browser since the task remains running in the background and rebuilding as necessary.

DevTools Server

Run and debug the local version of the server with a release build:

  • In VS Code on the Debug side bar, switch to the Run Server with Release Build config. Press F5. This will produce a release build of DevTools and then debug the server (bin/devtools.dart) to serve it.
  • From CLI, you can run the publish script to create a release build (./devtools/tool/publish.sh). Then cd packages/devtools and run dart bin/devtools.dart.

If you need to make breaking changes to DevTools that require changes to the server (such that DevTools cannot run against the live Pub version of devtools_server) it's critical that the devtools_server is released first and the version numbers in packages/devtools/pubspec.yaml and packages/devtools_app/pubspec.yaml are updated. Please make sure this is clear on any PRs you open.

Testing

Running tests

Make sure your Flutter SDK matches the tip of trunk before running these tests.

cd packages/devtools_app
flutter test -j1

The flag -j1 tells Flutter to run tests with 1 concurrent test runner. If your test run does not include the directory devtools_app/test/integration_tests, then you do not need to include this flag. For example, it is OK to do the following:

flutter test test/ui/

Updating golden files

Some of the golden file tests will fail if Flutter changes the implementation or diagnostic properties of widgets used by the inspector tests. If this happens, make sure the golden file output still looks reasonable and execute the following command to update the golden files.

./tool/update_goldens.sh

This will update the master or stable goldens depending on whether you're on the stable Flutter branch.

To update goldens for both channels do:

flutter channel master
./tool/update_goldens.sh
flutter channel stable
./tool/update_goldens.sh

third_party dependencies

All content not authored by the Flutter team must go in the third_party directory. As an expedient to make the third_party code work well with our build scripts, code in third_party should be given a stub pubspec.yaml file so that you can reference the resources from the packages directory from packages/devtools_app/web/index.html