From 1a80bd3830a214bb7be5559f637e089cbbcb9636 Mon Sep 17 00:00:00 2001 From: "Max R. P. Grossmann" Date: Tue, 30 Dec 2025 12:02:22 +1100 Subject: [PATCH 1/2] Disable Enter for form submission --- src/uproot/default/Bare.html | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/uproot/default/Bare.html b/src/uproot/default/Bare.html index 2feeae1..c056809 100644 --- a/src/uproot/default/Bare.html +++ b/src/uproot/default/Bare.html @@ -236,6 +236,16 @@
// deanchor sliders uproot.slidersWithoutAnchoring(); + + // disable Enter for form submission + + document.querySelectorAll("form").forEach((form) => { + form.addEventListener("keydown", (e) => { + if (e.key === "Enter" && e.target.tagName !== "TEXTAREA") { + e.preventDefault(); + } + }); + }); }); uproot.onReady(() => { From 25004e8cad41d0c5a9497017435cdb180fcb1628 Mon Sep 17 00:00:00 2001 From: "Max R. P. Grossmann" Date: Mon, 2 Feb 2026 20:35:11 +1100 Subject: [PATCH 2/2] Implement --no-enter (PR #139) --- src/uproot/cli.py | 3 +++ src/uproot/default/Bare.html | 18 ++++++++++-------- src/uproot/deployment.py | 1 + src/uproot/pages.py | 1 + 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/src/uproot/cli.py b/src/uproot/cli.py index 16c3024..23d6b29 100644 --- a/src/uproot/cli.py +++ b/src/uproot/cli.py @@ -124,6 +124,7 @@ def cli() -> None: @click.command(help="Run this uproot project") @click.option("--host", "-h", default="127.0.0.1", show_default="127.0.0.1", help="Host") @click.option("--port", "-p", default=8000, show_default=8000, help="Port") +@click.option("--no-enter", default=False, is_flag=True, help="Disable form submission via Enter") @click.option("--unsafe", default=False, is_flag=True, help="Run without admin authentication") @click.option("--public-demo", default=False, is_flag=True, help="Run a public demo (use with --unsafe)") @click.pass_context @@ -132,6 +133,7 @@ def run( ctx: click.Context, host: str, port: int, + no_enter: bool, unsafe: bool, public_demo: bool, ) -> None: @@ -140,6 +142,7 @@ def run( d.HOST = host d.PORT = port + d.NO_ENTER = no_enter d.UNSAFE = unsafe d.PUBLIC_DEMO = public_demo diff --git a/src/uproot/default/Bare.html b/src/uproot/default/Bare.html index fbb59e1..4738a35 100644 --- a/src/uproot/default/Bare.html +++ b/src/uproot/default/Bare.html @@ -237,15 +237,17 @@
uproot.slidersWithoutAnchoring(); - // disable Enter for form submission - - document.querySelectorAll("form").forEach((form) => { - form.addEventListener("keydown", (e) => { - if (e.key === "Enter" && e.target.tagName !== "TEXTAREA") { - e.preventDefault(); - } + if (ui.no_enter) { + // disable Enter for form submission + + document.querySelectorAll("form").forEach((form) => { + form.addEventListener("keydown", (e) => { + if (e.key === "Enter" && e.target.tagName !== "TEXTAREA") { + e.preventDefault(); + } + }); }); - }); + } // clear selection feature for non-required radios diff --git a/src/uproot/deployment.py b/src/uproot/deployment.py index 393031c..4a19741 100644 --- a/src/uproot/deployment.py +++ b/src/uproot/deployment.py @@ -37,6 +37,7 @@ LANGUAGE: ISO639 = "en" LOGIN_TOKEN: Optional[str] = None LOGGER: Any = logging.getLogger("uproot") +NO_ENTER: bool = False ORIGIN: Optional[str] = os.getenv("UPROOT_ORIGIN") # Auto-detect Heroku app URL if not explicitly set diff --git a/src/uproot/pages.py b/src/uproot/pages.py index e6015c1..2d90e9c 100644 --- a/src/uproot/pages.py +++ b/src/uproot/pages.py @@ -209,6 +209,7 @@ async def render( sname=sname, thisis=thisis, uname=uname, + no_enter=d.NO_ENTER, ) | (metadata if metadata is not None else {}) )