Skip to content
This repository was archived by the owner on Jan 24, 2019. It is now read-only.

Commit 897484c

Browse files
author
Christopher De Cairos
committed
Implement new webmaker login
1 parent 77db907 commit 897484c

7 files changed

Lines changed: 42 additions & 41 deletions

File tree

Gruntfile.coffee

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ module.exports = (grunt) ->
1616
'app/_bower_components/locompleter/locompleter.js'
1717
'app/_bower_components/webmaker-analytics/analytics.js'
1818
'app/_bower_components/spiiin/src/spiiin.js'
19-
'app/_bower_components/webmaker-login-angular/dist/ngWebmakerLogin.js'
20-
'app/_bower_components/webmaker-login-angular/dist/templates/ngWebmakerLogin.templates.js'
19+
'app/_bower_components/webmaker-login-ux/dist/ngWebmakerLogin.js'
20+
'app/_bower_components/webmaker-login-ux/dist/templates/ngWebmakerLogin.templates.js'
2121
'app/_js/app.js'
2222
'app/_js/services.js'
2323
'app/_js/controllers.js'

app/_js/app.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ angular.module('wmProfile', [
1515
config(['$routeProvider', '$locationProvider',
1616
function ($routeProvider, $locationProvider) {
1717
$routeProvider.when('/:locale?/user/:username/badges', {
18-
templateUrl: '/user/_partials/badges.html',
19-
controller: 'badges'
20-
})
18+
templateUrl: '/user/_partials/badges.html',
19+
controller: 'badges'
20+
})
2121
.when('/:locale?/user/:username/badges', {
2222
templateUrl: '/user/_partials/badges.html',
2323
controller: 'badges'
@@ -59,10 +59,10 @@ run(['$rootScope', '$http', 'jQuery',
5959
};
6060

6161
$.ajax({
62-
async: false,
63-
url: '/user/_service/env.json',
64-
dataType: 'json'
65-
})
62+
async: false,
63+
url: '/user/_service/env.json',
64+
dataType: 'json'
65+
})
6666
.done(function (config) {
6767
$rootScope.WMP.config = config;
6868
// Set locale information

app/_js/directives.js

Lines changed: 29 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -12,35 +12,37 @@ angular.module('wmProfile.directives', [])
1212
}
1313
};
1414
})
15-
.directive('wmpSrc', ['jQuery', function (jQuery) {
16-
// Add wmp-src to an img to only give it a src if the target is loadable
17-
// This prevents broken images from displaying and creates hooks for other display logic
18-
return {
19-
restrict: 'A',
20-
scope: {
21-
url: '@wmpSrc',
22-
didFail: '=wmpSrcFailed'
23-
},
24-
link: function ($scope, el, attrs) {
25-
var elLoader = jQuery('<img>');
26-
el.fadeTo(0, 0);
27-
28-
elLoader.on('load', function () {
29-
el.attr('src', $scope.url).fadeTo(200, 1);
30-
$scope.didFail = false;
31-
$scope.$apply();
32-
});
15+
.directive('wmpSrc', ['jQuery',
16+
function (jQuery) {
17+
// Add wmp-src to an img to only give it a src if the target is loadable
18+
// This prevents broken images from displaying and creates hooks for other display logic
19+
return {
20+
restrict: 'A',
21+
scope: {
22+
url: '@wmpSrc',
23+
didFail: '=wmpSrcFailed'
24+
},
25+
link: function ($scope, el, attrs) {
26+
var elLoader = jQuery('<img>');
27+
el.fadeTo(0, 0);
3328

34-
elLoader.on('error', function () {
35-
$scope.didFail = true;
36-
$scope.$apply();
37-
});
29+
elLoader.on('load', function () {
30+
el.attr('src', $scope.url).fadeTo(200, 1);
31+
$scope.didFail = false;
32+
$scope.$apply();
33+
});
3834

39-
// Attempt to load target image in a non attached IMG element
40-
elLoader.attr('src', $scope.url);
41-
}
42-
};
43-
}])
35+
elLoader.on('error', function () {
36+
$scope.didFail = true;
37+
$scope.$apply();
38+
});
39+
40+
// Attempt to load target image in a non attached IMG element
41+
elLoader.attr('src', $scope.url);
42+
}
43+
};
44+
}
45+
])
4446
.directive('wmpLogin', ['$rootScope',
4547
function ($rootScope) {
4648
return {

app/_less/components/imports.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
@import "../_bower_components/selectize/dist/less/selectize";
1515

1616
// Webmaker Login
17-
@import "../_bower_components/webmaker-login-angular/dist/css/webmakerLogin.css";
17+
@import "../_bower_components/webmaker-login-ux/dist/css/webmakerLogin.css";

bower.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@
2020
"selectize": "0.9.0",
2121
"makeapi-client": "https://github.com/mozilla/makeapi-client.git#v0.5.24",
2222
"makerstrap": "0.1.3",
23-
"webmaker-auth-client": "0.1.11",
24-
"webmaker-login-angular": "https://github.com/cadecairos/webmaker-login-angular/archive/8ba3f24d7f68b784a75b75387165b44c175f7430.tar.gz",
23+
"webmaker-login-ux": "1.0.1",
2524
"ngInfiniteScroll": "1.1.2",
2625
"spiiin": "0.2.0"
2726
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"morgan": "1.0.1",
2323
"newrelic": "1.5.5",
2424
"optimist": "0.6.1",
25-
"webmaker-auth": "0.1.4",
25+
"webmaker-auth": "0.2.1",
2626
"webmaker-i18n": "0.3.22",
2727
"webmaker-locale-mapping": "0.0.5",
2828
"webmaker-translation-stats": "0.0.1",

server/server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ module.exports = function (config) {
5555
translation_directory: path.resolve(__dirname, '../locale')
5656
}));
5757

58-
var webmakerLoginJSON = require('../app/_bower_components/webmaker-login-angular/locale/en_US/webmaker-login.json');
58+
var webmakerLoginJSON = require('../app/_bower_components/webmaker-login-ux/locale/en_US/webmaker-login.json');
5959

6060
i18n.addLocaleObject({
6161
'en-US': webmakerLoginJSON

0 commit comments

Comments
 (0)