Skip to content
This repository was archived by the owner on Nov 11, 2019. It is now read-only.
This repository was archived by the owner on Nov 11, 2019. It is now read-only.

[shipit] There is no suggested revision, nor error message when the last commits of a repository are all DONTBUILD #2235

@JohanLorenzo

Description

@JohanLorenzo

It happened today with ESR68. @pascalchevrel and I were really confused. Nothing came up:

image

After some investigation, these lines are filtering all commits out:

const suggestedRevisions = Object.values(pushes.pushes).map(push =>
({ ...push.changesets[0], date: new Date(push.date * 1000) })).reverse().filter(push =>
push.desc.indexOf('DONTBUILD') === -1);

image

I think we should show a warning explaining why nothing comes up.

What do you think @rail ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions