From 8284535757bcb2e59c7f7f80ab2081757e5e8cec Mon Sep 17 00:00:00 2001 From: Stephanie Hobson Date: Fri, 23 Jan 2026 12:58:37 -0800 Subject: [PATCH] Fix remaining mixed-decls warnings --- .../sass/protocol/base/elements/_forms.scss | 12 ++++----- .../sass/protocol/base/elements/_lists.scss | 16 ++++++------ .../sass/protocol/base/elements/_quotes.scss | 2 +- .../sass/protocol/base/elements/_tables.scss | 4 +-- .../protocol/base/utilities/_rich-text.scss | 6 ++--- assets/sass/protocol/components/_article.scss | 4 +-- .../sass/protocol/components/_breadcrumb.scss | 2 +- assets/sass/protocol/components/_card.scss | 6 ++--- assets/sass/protocol/components/_footer.scss | 24 ++++++++--------- .../components/_language-switcher.scss | 2 +- .../sass/protocol/components/_menu-item.scss | 6 ++--- .../sass/protocol/components/_menu-list.scss | 6 ++--- assets/sass/protocol/components/_menu.scss | 10 +++---- assets/sass/protocol/components/_modal.scss | 2 +- .../sass/protocol/components/_navigation.scss | 26 +++++++++++-------- .../components/_notification-bar.scss | 17 ++++++------ assets/sass/protocol/components/_picto.scss | 10 +++---- .../protocol/components/_sidebar-menu.scss | 18 ++++++------- .../protocol/components/_sticky-promo.scss | 18 ++++++------- .../components/forms/_button-container.scss | 6 ++--- .../protocol/components/forms/_choice.scss | 14 +++++----- .../sass/protocol/components/forms/_msg.scss | 2 +- .../sass/protocol/components/logos/_logo.scss | 4 +-- .../protocol/components/logos/_wordmark.scss | 4 +-- .../sass/protocol/includes/forms/index.scss | 2 +- .../sass/protocol/includes/mixins/_bidi.scss | 2 +- .../protocol/includes/mixins/_details.scss | 2 +- .../sass/protocol/templates/_card-layout.scss | 10 +++---- docs/02-usage/02-framework.md | 2 +- theme/assets/sass/components/_pen.scss | 2 +- 30 files changed, 122 insertions(+), 119 deletions(-) diff --git a/assets/sass/protocol/base/elements/_forms.scss b/assets/sass/protocol/base/elements/_forms.scss index b00601d8c..d10a2a369 100644 --- a/assets/sass/protocol/base/elements/_forms.scss +++ b/assets/sass/protocol/base/elements/_forms.scss @@ -113,8 +113,8 @@ label { @include forms.field-label; &.mzp-u-inline { - @include bidi(((padding, 0 $spacing-sm 0 0, 0 0 0 $spacing-sm),)); display: inline; + @include bidi(((padding, 0 $spacing-sm 0 0, 0 0 0 $spacing-sm),)); } } @@ -301,11 +301,6 @@ input[type='file'] { select { appearance: none; box-sizing: border-box; - @include bidi(( - (background-position, right 8px top 50%, left 8px top 50%), - (padding, forms.$field-padding forms.$symbol-spacing forms.$field-padding forms.$field-padding, forms.$field-padding forms.$field-padding forms.$field-padding forms.$symbol-spacing), - )); - @include forms.form-input; background-image: $url-image-caret-down-form, forms.$select-bg; background-repeat: no-repeat, repeat; background-size: 1em auto, 100%; @@ -314,6 +309,11 @@ select { max-width: 100%; min-width: forms.$field-min-width; text-overflow: ellipsis; + @include forms.form-input; + @include bidi(( + (background-position, right 8px top 50%, left 8px top 50%), + (padding, forms.$field-padding forms.$symbol-spacing forms.$field-padding forms.$field-padding, forms.$field-padding forms.$field-padding forms.$field-padding forms.$symbol-spacing), + )); // no down arrow on multi selects &[multiple] { diff --git a/assets/sass/protocol/base/elements/_lists.scss b/assets/sass/protocol/base/elements/_lists.scss index 7b40621d5..6140dce2b 100644 --- a/assets/sass/protocol/base/elements/_lists.scss +++ b/assets/sass/protocol/base/elements/_lists.scss @@ -13,44 +13,44 @@ ol { } ul.mzp-u-list-styled { - @include bidi(((margin-left, $layout-sm, margin-right, 0),)); list-style: disc; + @include bidi(((margin-left, $layout-sm, margin-right, 0),)); li { margin-bottom: 0.25em; } ul { - @include bidi(((margin-left, $layout-xs, margin-right, 0),)); list-style: circle; margin-bottom: 0; + @include bidi(((margin-left, $layout-xs, margin-right, 0),)); } ol { - @include bidi(((margin-left, $layout-xs, margin-right, 0),)); list-style: decimal; margin-bottom: 0; + @include bidi(((margin-left, $layout-xs, margin-right, 0),)); } } ol.mzp-u-list-styled { - @include bidi(((margin-left, $layout-sm, margin-right, 0),)); list-style: decimal; + @include bidi(((margin-left, $layout-sm, margin-right, 0),)); li { margin-bottom: 0.25em; } ol { - @include bidi(((margin-left, $layout-xs, margin-right, 0),)); list-style: lower-alpha; margin-bottom: 0; + @include bidi(((margin-left, $layout-xs, margin-right, 0),)); } ul { - @include bidi(((margin-left, $layout-xs, margin-right, 0),)); list-style: disc; margin-bottom: 0; + @include bidi(((margin-left, $layout-xs, margin-right, 0),)); } } @@ -61,14 +61,14 @@ dl.mzp-u-list-styled { } dd { - @include bidi(((margin-left, $layout-xs, margin-right, 0),)); margin-bottom: 0.25em; + @include bidi(((margin-left, $layout-xs, margin-right, 0),)); } ul, ol { - @include bidi(((margin-left, $layout-xs, margin-right, 0),)); margin-bottom: 0; + @include bidi(((margin-left, $layout-xs, margin-right, 0),)); } ul { diff --git a/assets/sass/protocol/base/elements/_quotes.scss b/assets/sass/protocol/base/elements/_quotes.scss index 1fd48007b..fa3cc74ad 100644 --- a/assets/sass/protocol/base/elements/_quotes.scss +++ b/assets/sass/protocol/base/elements/_quotes.scss @@ -5,7 +5,6 @@ @use '../../includes/lib' as *; blockquote { - @include bidi(((border-width, 0 0 0 5px, 0 5px 0 0),)); @include text-heading-sm; border-color: $color-marketing-gray-20; border-style: solid; @@ -13,6 +12,7 @@ blockquote { font-weight: bold; margin: $spacing-lg auto; padding: $spacing-sm $spacing-lg; + @include bidi(((border-width, 0 0 0 5px, 0 5px 0 0),)); cite { @include text-heading-xs; diff --git a/assets/sass/protocol/base/elements/_tables.scss b/assets/sass/protocol/base/elements/_tables.scss index 1b952282a..98896b672 100644 --- a/assets/sass/protocol/base/elements/_tables.scss +++ b/assets/sass/protocol/base/elements/_tables.scss @@ -12,17 +12,17 @@ border-spacing: 0; caption { - @include bidi(((text-align, left, right),)); margin-bottom: 0.25em; width: 100%; + text-align: start; } th, td { - @include bidi(((text-align, left, right),)); border-top: 1px solid rgb(0, 0, 0, 0.2); padding: 0.5em 10px; text-align: left; + text-align: start; } thead th, diff --git a/assets/sass/protocol/base/utilities/_rich-text.scss b/assets/sass/protocol/base/utilities/_rich-text.scss index 7b1aadc92..a95b5a2d1 100644 --- a/assets/sass/protocol/base/utilities/_rich-text.scss +++ b/assets/sass/protocol/base/utilities/_rich-text.scss @@ -54,8 +54,8 @@ } ul { - @include bidi(((margin-left, $layout-sm, margin-right, 0),)); list-style-type: disc; + @include bidi(((margin-left, $layout-sm, margin-right, 0),)); ul { list-style-type: circle; @@ -63,8 +63,8 @@ } ol { - @include bidi(((margin-left, $layout-sm, margin-right, 0),)); list-style-type: decimal; + @include bidi(((margin-left, $layout-sm, margin-right, 0),)); ol { list-style-type: lower-roman; @@ -85,8 +85,8 @@ } dd { - @include bidi(((margin-left, $layout-xs, margin-right, 0),)); margin-bottom: 0.25em; + @include bidi(((margin-left, $layout-xs, margin-right, 0),)); } pre { diff --git a/assets/sass/protocol/components/_article.scss b/assets/sass/protocol/components/_article.scss index 881261ce5..77705418b 100644 --- a/assets/sass/protocol/components/_article.scss +++ b/assets/sass/protocol/components/_article.scss @@ -11,12 +11,12 @@ @media #{$mq-md} { // Float left when sidebar is on the left .mzp-l-sidebar-left .mzp-l-main & { - @include bidi(((float, left, right),)); + float: inline-start; } // Float right when sidebar is on the right .mzp-l-sidebar-right .mzp-l-main & { - @include bidi(((float, right, left),)); + float: inline-end; } } } diff --git a/assets/sass/protocol/components/_breadcrumb.scss b/assets/sass/protocol/components/_breadcrumb.scss index 43d2434e8..4d084605a 100644 --- a/assets/sass/protocol/components/_breadcrumb.scss +++ b/assets/sass/protocol/components/_breadcrumb.scss @@ -28,9 +28,9 @@ + .mzp-c-breadcrumb-item { &::before { - @include bidi(((content, '\2192', '\2190'),)); font-weight: normal; margin: 0 0.25em; + @include bidi(((content, '\2192', '\2190'),)); } } diff --git a/assets/sass/protocol/components/_card.scss b/assets/sass/protocol/components/_card.scss index 8615559a2..5d86e0c52 100644 --- a/assets/sass/protocol/components/_card.scss +++ b/assets/sass/protocol/components/_card.scss @@ -54,13 +54,13 @@ &.mzp-has-video .mzp-c-card-tag, &.mzp-has-audio .mzp-c-card-tag { + background-repeat: no-repeat; + line-height: 1.8; + min-height: 25px; @include bidi(( (background-position, center left, center right), (padding-left, $spacing-xl, padding-right, 0), )); - background-repeat: no-repeat; - line-height: 1.8; - min-height: 25px; } &.mzp-has-video .mzp-c-card-tag { diff --git a/assets/sass/protocol/components/_footer.scss b/assets/sass/protocol/components/_footer.scss index adc582e48..22912a75d 100644 --- a/assets/sass/protocol/components/_footer.scss +++ b/assets/sass/protocol/components/_footer.scss @@ -72,9 +72,9 @@ // Footer section containing list and heading .mzp-c-footer-sections { - @include clearfix; - @include footer-line; padding-bottom: $layout-sm; + @include footer-line; + @include clearfix; @media #{$mq-sm} { padding-bottom: 0; @@ -100,11 +100,11 @@ } @media (min-width: #{$screen-sm}) and (max-width: #{$screen-lg - 1px}) { - @include bidi(((float, left, right),)); @include grid-half; + float: inline-start; &:nth-child(odd) { - @include bidi(((clear, left, right),)); + clear: inline-start; @include bidi(((padding, 0 ($layout-md * 0.5) 0 0, 0 0 0 ($layout-md * 0.5)),)); } @@ -116,8 +116,8 @@ @media #{$mq-lg} { .mzp-c-footer-section { - @include bidi(((float, left, right),)); padding: 0 ($layout-md * 0.5); + float: inline-start; &:first-child { @include bidi(((padding, 0 ($layout-md * 0.5) 0 0, 0 0 0 ($layout-md * 0.5)),)); @@ -151,10 +151,10 @@ padding: $spacing-md 0; position: relative; width: 100%; - @include bidi(((text-align, left, right),)); @include footer-line; @include text-body-md; @include font-mozilla-text; + text-align: start; /* stylelint-disable-next-line no-duplicate-selectors */ & { @@ -178,7 +178,6 @@ button::before { background: $url-image-expand-white top left no-repeat; background-size: 24px, 24px; - @include bidi(((right, 8px, left, auto),)); transition: transform 100ms ease-in-out; content: ''; height: 24px; @@ -186,6 +185,7 @@ position: absolute; top: 50%; width: 24px; + @include bidi(((right, 8px, left, auto),)); } button[aria-expanded='true']::before { @@ -255,7 +255,7 @@ margin-bottom: $layout-sm; @media #{$mq-md} { - @include bidi(((float, right, left),)); + float: inline-end; } } @@ -266,9 +266,9 @@ margin-bottom: $layout-sm; li { - @include bidi(((margin, 0 $spacing-md 0 0, 0 0 0 $spacing-md),)); display: inline-block; vertical-align: bottom; + @include bidi(((margin, 0 $spacing-md 0 0, 0 0 0 $spacing-md),)); a { @include image-replaced; @@ -298,12 +298,12 @@ } @media #{$mq-md} { - @include bidi(((right, 0, left, auto),)); - @include bidi(((text-align, right, left),)); bottom: 0; margin-bottom: 0; max-width: 33%; // don't over lap with legal links position: absolute; + @include bidi(((right, 0, left, auto),)); + text-align: end; li { @include bidi(( @@ -329,8 +329,8 @@ @media #{$mq-md} { li { - @include bidi(((padding, 0 $spacing-lg 0 0, 0 0 0 $spacing-lg),)); display: inline-block; + @include bidi(((padding, 0 $spacing-lg 0 0, 0 0 0 $spacing-lg),)); &:last-child { @include bidi(((padding-right, 0, padding-left, 0),)); diff --git a/assets/sass/protocol/components/_language-switcher.scss b/assets/sass/protocol/components/_language-switcher.scss index 2a67994af..1d0f37a80 100644 --- a/assets/sass/protocol/components/_language-switcher.scss +++ b/assets/sass/protocol/components/_language-switcher.scss @@ -11,8 +11,8 @@ label, .mzp-c-language-switcher-link { display: inline-block; - @include bidi(((margin, 0 $spacing-lg $spacing-sm 0, 0 0 $spacing-sm $spacing-lg),)); font-size: var(--theme-body-font-size-sm); // just want smaller text size, so don't use full mixin + @include bidi(((margin, 0 $spacing-lg $spacing-sm 0, 0 0 $spacing-sm $spacing-lg),)); } // hide the