Skip to content

Better handle the wait for opening windows #65

@whimboo

Description

@whimboo

Currently we have code like this:

       return self.wait.until(
            expected.new_browser_window_is_opened(
                self.selenium, handles_before),

Problem is that each consumer of the expected method would have to retrieve the handles before.

I propose that we get rid of this expected method, and replace it with whether a context manager, or having a callback. In both situations the wait will happen totally transparent to the consumer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions