Bump Python to 3.11.1 (#532)

This commit bumps the version of Python we use to run CTMS from 3.10.9 to 3.11.1.

In order to complete the upgrade, we also had to:

   - update `pylint`, and make some related changes
   - re-add `uvicorn` so we pulled in `uvloop>=0.17`

Author: grahamalama

.github/workflows/lint.yaml

@@ -11,7 +11,7 @@ jobs:
         run: pipx install poetry==1.3.2
       - uses: actions/setup-python@v4
         with:
-          python-version: "3.10.9"
+          python-version: "3.11.1"
           cache: "poetry"
       - name: Install dependencies
         run: poetry install

.github/workflows/test-build.yaml

@@ -28,7 +28,7 @@ jobs:
         run: pipx install poetry==1.3.2
       - uses: actions/setup-python@v4
         with:
-          python-version: "3.10.9"
+          python-version: "3.11.1"
           cache: "poetry"
       - name: Install dependencies
         run: poetry install

Dockerfile

@@ -1,4 +1,4 @@
-FROM python:3.10.9 as python-base
+FROM python:3.11.1 as python-base
 
 ENV PIP_DEFAULT_TIMEOUT=100 \
     PIP_DISABLE_PIP_VERSION_CHECK=on \
@@ -16,7 +16,7 @@ WORKDIR $PYSETUP_PATH
 COPY ./poetry.lock ./pyproject.toml ./
 RUN $POETRY_HOME/bin/poetry install --no-dev --no-root
 
-FROM python:3.10.9-slim as production
+FROM python:3.11.1-slim as production
 
 COPY bin/update_and_install_system_packages.sh /opt
 RUN opt/update_and_install_system_packages.sh libpq5

ctms/app.py

@@ -94,8 +94,9 @@
 
 # We could use the default prometheus_client.REGISTRY, but it makes tests
 # easier to write if it is possible to replace the registry with a fresh one.
+# pylint: disable-next=unnecessary-lambda-assignment
 get_metrics_registry = lambda: METRICS_REGISTRY
-get_metrics = lambda: METRICS
+get_metrics = lambda: METRICS  # pylint: disable=unnecessary-lambda-assignment
 oauth2_scheme = OAuth2ClientCredentials(tokenUrl="token")
 token_scheme = HTTPBasic(auto_error=False)
 
@@ -359,6 +360,7 @@ def get_pubsub_claim(
 ):
     for name in ("audience", "email", "client"):
         if not pubsub_settings[name]:
+            # pylint: disable-next=broad-exception-raised
             raise Exception(f"PUBSUB_{name.upper()} is unset")
 
     credentials_exception = HTTPException(

ctms/ingest.py

@@ -25,6 +25,7 @@ def finalize(self):
                 missing.append(name)
 
         if missing:
+            # pylint: disable-next=broad-exception-raised
             raise BaseException(f"Must provide data for all tables. Missing {missing}")
 
 

ctms/sync.py

@@ -205,14 +205,17 @@ def check_healthcheck(healthcheck_path, age_s):
     Return the current age.
     """
     if not healthcheck_path:
+        # pylint: disable-next=broad-exception-raised
         raise Exception("BACKGROUND_HEALTHCHECK_PATH not set")
     if age_s is None:
+        # pylint: disable-next=broad-exception-raised
         raise Exception("BACKGROUND_HEALTHCHECK_AGE_S not set")
     with open(healthcheck_path, "r", encoding="utf8") as health_file:
         content = health_file.read().strip()
         written_at = datetime.fromisoformat(content)
         health_age_raw = (datetime.now(tz=timezone.utc) - written_at).total_seconds()
         health_age = round(health_age_raw, 3)
         if health_age > age_s:
+            # pylint: disable-next=broad-exception-raised
             raise Exception(f"Age {health_age}s > {age_s}s, written at {content}")
     return health_age

poetry.lock

@@ -11,7 +11,7 @@ authors = ["CTMS Reviewers <@mozilla-it/ctms-reviewers>"]
 
 [tool.poetry.dependencies]
 # These packages are mandatory and form the core of this package’s distribution.
-python = "3.10.9"
+python = "3.11.1"
 fastapi = "^0.84.0"
 starlette = "^0.19.1"
 requests = "^2.28.1"
@@ -46,7 +46,7 @@ types-python-dateutil = "^2.8.19"
 detect-secrets = "^1.4.0"
 bandit = "^1.7.0"
 SQLAlchemy-Utils = "^0.39.0"
-pylint = "^2.13.9"
+pylint = "^2.16.0"
 pylint-pytest = "^1.1.2"
 types-requests = "^2.28.11"
 
@@ -58,18 +58,13 @@ testpaths = [
 [tool.pylint]
     [tool.pylint.'MESSAGES CONTROL']
     disable = [
-        # https://black.readthedocs.io/en/stable/compatible_configs.html
-        "C0330",
-        "C0326",
-
         "R0801", # sqla has a lot of duplicate code and it is work to "fix" this
         "C0301", # if black is happy with the line-length, let's not mess with it
         "R0903", # this is triggered by pydantic's config and is really just a taste thing anyway
         "R0913", # we have too-many-arguments in too many places to easily fix
         "R0912", # Same idea as above, let's leave it since it is a matter of taste
         "W0511", # Let us have our TODOs
         "W0613", # sometimes unused arguments are nice for symmetry and also api methods
-        "R0201", # Not using "self" when it is defined is a matter of taste
         "R0914", # Leave me alone, pylint. I can have as many locals as I want
 
         "C0114", # mozilla-it/ctms-api#100
@@ -120,7 +115,7 @@ profile = "black"
 
 [tool.mypy]
 # Sync Python version with Dockerfile
-python_version = "3.10.9"
+python_version = "3.11"
 # Look for errors in this file
 warn_unused_configs = true