A List of Issues - July 18, 2023

[StarOfChorusim]

Hiya Mouse! It's awesome to see this module updated to cover some of the previous issues and such folks were having,, but I wanted to pop in and give you a list of things that me and some follow DMs have noticed after playing around for a couple hours.

• Trusted Players are not affected by enabling the GM Theme. I know this was a previous issue, would there be a way to devise a good fix for this.
• There is an element for feature cards in chat that we can't seem to find the option for changing that makes things unreadable, is this something that is hardbaked into Foundry?
  
• Overall, the options available underneath the Foundry Virtual Tabletop Tab could do with greater documentation like it does in the LibThemer Tab, as it's hard to tell what changes what in the themeing and can make for confusion and a degree of information overload.
  
  
• A weird additional issue is that the theme I have as my preset never sticks for me and I can't quite figure out why.

I'm loving what we're seeing thus far with this module though! It's so close to what I've been asking for, for ages!

[mouse0270]

• Trusted Players are not affected by enabling the GM Theme. I know this was a previous issue, would there be a way to devise a good fix for this.

  • Some settings do not take effect until after player refreshes their screen.

• There is an element for feature cards in chat that we can't seem to find the option for changing that makes things unreadable, is this something that is hardbaked into Foundry?

• Overall, the options available underneath the Foundry Virtual Tabletop Tab could do with greater documentation like it does in the LibThemer Tab, as it's hard to tell what changes what in the themeing and can make for confusion and a degree of information overload.

• A weird additional issue is that the theme I have as my preset never sticks for me and I can't quite figure out why.

• For the trusted player, I don't appear to be having this issue, https://streamable.com/7qjngh I may need more details on whats happening. As it appears to be working fine for me. I will admit, it does look that the player does need to reload for some effects, which I will look into.

• I have fixed the text for the title, at least for the D&D5e System, but I would need your preset or more specific details about the styles of that button to know why its not working, mine seem fine:
  I suspect this might be a module or system conflict because your chat header looks different than mine with an image and dark time/delete options. So maybe another module is effecting these button styles. If you know how to, can you open the development console and send me the css options related to this, otherwise, I would need to have your theme and module list.

• Yeah, the Foundry VTT variables do need better documentation, the problem is, these variables are just the variables from foundry style sheet, there is no documentation on them, however I am welling to accept any ones documentation on what those css variables are and what they are used for. I simply do not have this information.

• Theme Settings are a client setting, meaning switching browsers or clearing your browsers caches will clear the theme? Could one of these be causing this issue? Other then that, I am not sure why you would be losing those options.

[StarOfChorusim]

First off, I wanted to thank you for your swift response, Mouse! I can only imagine all the work you put into your day to day so I appreciate you taking the time out of your day to help where you can.

---

Before I proceed to responding to your other points, I see that you're on V11. I'm on V10, so it's likely there's some form of System Version discrepancy that's getting in the way. Admittedly, I don't know how much that would effect things.

Now onto each point:

1. I'll make a note about informing Trusted Players to refresh if the module isn't taking effect for them.
2. I'll attach my preset for you to take a look at, as well as my module list...which is admittedly quite extensive so it's quite likely that things are heavily conflicting with one another. I won't expect you to look at all of the contingencies on your own, so at some point during my free time this week I'll look into which of my modules could be causing the difference.
   Modules - StarOfChorusim Module List.txt
   Starry Slate Preset - https://drive.google.com/file/d/1FFLZ5xOOHiHVZ4lvm6YofftFIDr3S2Zh/view?usp=sharing
3. Oh no D: That's wild that there's no available documentation provided on those variables, that's very unhelpful if you want to provide clarity. Definitely not your fault. Sadly I'm not someone who can find or provide that either. Hopefully we can find someone who can!
4. I really only clear my browser cache once every 3 months and only stick to one browser unless something weird happens so this may just be one of those weird anomalies that happens when I put my hands on something. Hardly the first time and why all my friends call me their favorite playtester.

[StarOfChorusim]

So even turning everything else off except my module management stuff and then tried turning off those and it wouldn't change the little hang up I have with the title on that card. It's a smaller issue in my book at least. Just going to have to make sure to let my friends know who were curious too.
The only luck I had was adjusting the Deep Purple Color.

This might be a V10 quirk.

[mouse0270]

Oh my apologizes, I meant I have fixed the text and it will be included in the next update.

I am unable to identify what is causing the issue with your button though, as I am not experiencing that issue.

1. Your players shouldn't have to refresh, I will see what is causing this issue, refreshing is just a temporary fix until I can resolve it.

2. I imported your preset, but I am curious if something imported incorrectly. My chat cards don't look like yours. My windows look like this:
   

3. Yeah, the missing documentation on their css variables makes it quite difficult to give them descriptions. Also they don't appear to be used in consistent type locations. So even when I was going to try and document them, I couldn't make sense of them.

4. If you are losing your theme, the only thing I can think of is your local browser cache being reset, as I don't really do anything special there. Its just a standard client setting in foundry, and foundry just uses the browser local storage. So if you are clearing that or switching browsers, you would lose the settings. Not really an easy fix the for that. Though, there is a new persistent storage option in v11, so I might look into using that, it will help keep things consistent between players and even allow themes per would as the theme would be stored on the server instead of local browser session

[mouse0270]

I fixed some of these issues in v1.0.10. I will keep working on them as I can. Sorry for the delay.