From c8a994bf362b14df2707a631d6e1dbfde109e7c0 Mon Sep 17 00:00:00 2001 From: Ahmed Mohamed <61554040+ahmed777-android@users.noreply.github.com> Date: Wed, 30 Sep 2020 01:18:01 +0200 Subject: [PATCH] Update Login_Activity.java best practice --- .../task1/login_Activity/Login_Activity.java | 34 ++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/example/task1/login_Activity/Login_Activity.java b/app/src/main/java/com/example/task1/login_Activity/Login_Activity.java index 05050a1..6b76076 100644 --- a/app/src/main/java/com/example/task1/login_Activity/Login_Activity.java +++ b/app/src/main/java/com/example/task1/login_Activity/Login_Activity.java @@ -13,6 +13,8 @@ import com.example.task1.R; public class Login_Activity extends AppCompatActivity implements View.OnClickListener { + //will be better if you use camle case while named variable + //like userPass , userName EditText mUsername,mUserpass; Button mNextBtn,mSubmitBtn; @Override @@ -31,7 +33,7 @@ private void intiViews() { mSubmitBtn.setOnClickListener(this); } - @Override +/*@Override public void onClick(View view) { switch (view.getId()) { case R.id.submit_btn: @@ -59,6 +61,36 @@ else if (!(mUserpass.getText().toString().equalsIgnoreCase("123456789"))) { } + }*/ + @Override + public void onClick(View view) { + switch (view.getId()) { + case R.id.submit_btn: + if (!(mUsername.getText().toString().equals("mostafa@gmail.com")) &&!(mUsername.getText().toString().isEmpty())) { + Toast.makeText(Login_Activity.this, "please check your username", Toast.LENGTH_LONG).show(); + } + /* + else if ((mUsername.getText().toString().isEmpty())){ + Toast.makeText(Login_Activity.this, "please don't leave any field empty", Toast.LENGTH_LONG).show(); + } + */ + /* + else if ((mUserpass.getText().toString().isEmpty())) { + Toast.makeText(Login_Activity.this, "please don't leave any field empty", Toast.LENGTH_LONG).show(); + }*/ + else if (!(mUserpass.getText().toString().equals("123456789")) && !(mUserpass.getText().toString().isEmpty())) { + Toast.makeText(Login_Activity.this, "please check your password", Toast.LENGTH_SHORT).show(); + } else { + Toast.makeText(Login_Activity.this, "welcom", Toast.LENGTH_LONG).show(); + } + break; + case R.id.next_btn: + Intent i = new Intent(Login_Activity.this, Main_Activity.class); + startActivity(i); } + + } + + }