Generic sink; no more fMP4 (#34)

* A sink without fMP4.
* Make the sink generic.
* Small AI PR changes.

Author: kixelated

CLAUDE.md

@@ -4,7 +4,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ## Project Overview
 
-This is a GStreamer plugin for Media over QUIC (MoQ), written in Rust. It provides `hangsink` and `hangsrc` elements that enable publishing and subscribing to media streams using the MoQ protocol over QUIC transport.
+This is a GStreamer plugin for Media over QUIC (MoQ), written in Rust. It provides `moqsink` and `moqsrc` elements that enable publishing and subscribing to media streams using the MoQ protocol over QUIC transport.
 
 ## Development Setup
 
@@ -50,7 +50,7 @@ just fix
 just relay
 
 # Publish video stream with broadcast name
-just pub-gst bbb
+just pub bbb
 
 # Subscribe to video stream with broadcast name
 just sub bbb
@@ -59,35 +59,29 @@ just sub bbb
 ## Architecture
 
 ### Plugin Structure
-- **lib.rs**: Main plugin entry point, registers both sink and source elements as "hang" plugin
-- **sink/**: Hang sink element (`hangsink`) for publishing streams
-  - `mod.rs`: GStreamer element wrapper for HangSink
+- **lib.rs**: Main plugin entry point, registers both sink and source elements as "moq" plugin
+- **sink/**: MoQ sink element (`moqsink`) for publishing streams
+  - `mod.rs`: GStreamer element wrapper for MoqSink
   - `imp.rs`: Core implementation with async Tokio runtime
-- **source/**: Hang source element (`hangsrc`) for consuming streams  
-  - `mod.rs`: GStreamer element wrapper for HangSrc
+- **source/**: MoQ source element (`moqsrc`) for consuming streams
+  - `mod.rs`: GStreamer element wrapper for MoqSrc
   - `imp.rs`: Core implementation with async Tokio runtime
 
 ### Key Dependencies
-- **hang**: Higher-level hang protocol utilities and CMAF handling
+- **hang**: Higher-level protocol utilities and catalog/container handling
 - **moq-mux**: MoQ muxing/demuxing for media streams
 - **moq-lite**: Lightweight MoQ protocol types
 - **moq-native**: Core MoQ protocol implementation with QUIC/TLS
 - **gstreamer**: GStreamer bindings for Rust
-- **tokio**: Async runtime (single-threaded worker pool)
+- **tokio**: Async runtime
 
 ### Plugin Elements
-- `hangsink`: BaseSink element that accepts media data and publishes via MoQ with broadcast name
-- `hangsrc`: Bin element that receives MoQ streams and outputs GStreamer buffers
+- `moqsink`: Element with request pads (`video_%u`, `audio_%u`) that accepts media data and publishes via MoQ
+- `moqsrc`: Bin element that receives MoQ streams and outputs GStreamer buffers
 
-Both elements use a shared Tokio runtime and support TLS configuration options. They require broadcast names for operation.
+Both elements use a shared Tokio runtime and support TLS configuration options (url, broadcast, tls-disable-verify).
 
 ## Environment Variables
-- `RUST_LOG=info`: Controls logging level
-- `URL=http://localhost:4443`: Default relay server URL
-- `GST_PLUGIN_PATH`: Must include the built plugin directory
-
-## Notable Changes from moq-gst
-- Renamed from moq-gst to hang-gst
-- Element names changed from moqsink/moqsrc to hangsink/hangsrc
-- Added broadcast parameter requirement for both elements
-- Updated justfile commands to include broadcast parameters
+- `RUST_LOG`: Controls logging level (default: info, overridable via environment)
+- `URL`: Relay server URL (default: http://localhost:4443)
+- `GST_PLUGIN_PATH_1_0`: Must include the built plugin directory (handled automatically by justfile)

Cargo.lock

@@ -28,7 +28,6 @@ moq-native = "0.13.1"
 anyhow = { version = "1", features = ["backtrace"] }
 bytes = "1"
 gst = { package = "gstreamer", version = "0.23" }
-gst-base = { package = "gstreamer-base", version = "0.23" }
 #gst-app = { package = "gstreamer-app", version = "0.23", features = ["v1_20"] }
 
 tokio = { version = "1", features = ["full"] }

Cargo.toml

@@ -3,8 +3,8 @@
 # Using Just: https://github.com/casey/just?tab=readme-ov-file#installation
 
 export RUST_BACKTRACE := "1"
-export RUST_LOG := "info"
-export URL := "http://localhost:4443"
+export RUST_LOG := env_var_or_default("RUST_LOG", "info")
+export URL := "http://localhost:4443/anon"
 #export GST_DEBUG:="*:4"
 
 # List all of the available commands.
@@ -44,10 +44,11 @@ pub broadcast: (download "bbb" "http://commondatastorage.googleapis.com/gtv-vide
 	cargo build
 
 	# Run gstreamer and pipe the output to our plugin
-	GST_PLUGIN_PATH="${PWD}/target/debug${GST_PLUGIN_PATH:+:$GST_PLUGIN_PATH}" \
-	gst-launch-1.0 -v -e multifilesrc location="dev/bbb.fmp4" loop=true ! qtdemux name=demux \
-		demux.video_0 ! h264parse ! queue ! identity sync=true ! isofmp4mux name=mux chunk-duration=1 fragment-duration=1 ! moqsink url="$URL" broadcast="{{broadcast}}" tls-disable-verify=true \
-		demux.audio_0 ! aacparse ! queue ! mux.
+	GST_PLUGIN_PATH_1_0="${PWD}/target/debug${GST_PLUGIN_PATH_1_0:+:$GST_PLUGIN_PATH_1_0}" \
+	gst-launch-1.0 -v -e multifilesrc location="dev/bbb.fmp4" loop=true ! parsebin name=parse \
+		parse. ! queue ! identity sync=true ! mux.sink_0 \
+		parse. ! queue ! identity sync=true ! mux.sink_1 \
+		moqsink name=mux url="$URL" broadcast="{{broadcast}}" tls-disable-verify=true
 
 # Subscribe to a video using gstreamer
 sub broadcast:
@@ -56,7 +57,7 @@ sub broadcast:
 
 	# Run gstreamer and pipe the output to our plugin
 	# This will render the video to the screen
-	GST_PLUGIN_PATH="${PWD}/target/debug${GST_PLUGIN_PATH:+:$GST_PLUGIN_PATH}" \
+	GST_PLUGIN_PATH_1_0="${PWD}/target/debug${GST_PLUGIN_PATH_1_0:+:$GST_PLUGIN_PATH_1_0}" \
 	gst-launch-1.0 -v -e moqsrc url="$URL" broadcast="{{broadcast}}" tls-disable-verify=true ! decodebin ! videoconvert ! autovideosink
 
 # Run the CI checks