Skip to content
This repository was archived by the owner on Jun 17, 2020. It is now read-only.
This repository was archived by the owner on Jun 17, 2020. It is now read-only.

Characters per line #248

@Ruto8

Description

@Ruto8

Some time ago, we agreed that 80 characters are insuficient and started to use 100 characters per line as our guideline. I was looking for that in our guidelines, and when I couldn't find that, surprised I was.

Before making a pull-request with that, I think we need a discussion about template files. As I noticed, we're often exceeding 100 characters per line, becuase of BEM classes.
As an example:

  span.ui-typo__serif-bigger.ui-posts__dropdown-header.ui-posts__dropdown-bg-hack.post-list__state

I can think of 2 solutions

  1. Classes should be refactored, to be less than 100 characters (don't forget indentation)
  2. We shouldn't care about 100 characters in template files.

Is there anything we can do about it or how should we proceed?
Should we add this guideline at all?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions