change test

Author: sleepyStick

pymongo/asynchronous/client_session.py

@@ -708,10 +708,12 @@ async def callback(session, custom_arg, custom_kwarg=None):
         """
         start_time = time.monotonic()
         retry = 0
+        self._transaction_retry_backoffs = []
         while True:
             if retry:  # Implement exponential backoff on retry.
                 jitter = random.random()  # noqa: S311
                 backoff = jitter * min(_BACKOFF_INITIAL * (1.25**retry), _BACKOFF_MAX)
+                self._transaction_retry_backoffs.append(backoff)
                 await asyncio.sleep(backoff)
             retry += 1
             await self.start_transaction(

test/asynchronous/test_transactions.py

@@ -623,11 +623,15 @@ async def callback(session):
     async def test_transaction_backoff(self):
         client = async_client_context.client
         coll = client[self.db.name].test
+        # optionally set _backoff_initial to a higher value
+        _set_backoff_initial(client_session._BACKOFF_MAX)
         # set fail point to trigger transaction failure and trigger backoff
         await self.set_fail_point(
             {
                 "configureFailPoint": "failCommand",
-                "mode": {"times": 3},
+                "mode": {
+                    "times": 30
+                },  # sufficiently high enough such that the time effect of backoff is noticeable
                 "data": {
                     "failCommands": ["commitTransaction"],
                     "errorCode": 24,
@@ -643,16 +647,11 @@ async def test_transaction_backoff(self):
         async def callback(session):
             await coll.insert_one({}, session=session)
 
-        total_backoff = 0
         async with self.client.start_session() as s:
             await s.with_transaction(callback)
-            self.assertEqual(len(s._transaction_retry_backoffs), 3)
-            for backoff in s._transaction_retry_backoffs:
-                self.assertGreater(backoff, 0)
-                total_backoff += backoff
 
         end = time.monotonic()
-        self.assertGreaterEqual(end - start, total_backoff)
+        self.assertGreaterEqual(end - start, 1.25)  # 1 second
 
 
 class TestOptionsInsideTransactionProse(AsyncTransactionsBase):

test/test_transactions.py

@@ -611,11 +611,15 @@ def callback(session):
     def test_transaction_backoff(self):
         client = client_context.client
         coll = client[self.db.name].test
+        # optionally set _backoff_initial to a higher value
+        _set_backoff_initial(client_session._BACKOFF_MAX)
         # set fail point to trigger transaction failure and trigger backoff
         self.set_fail_point(
             {
                 "configureFailPoint": "failCommand",
-                "mode": {"times": 3},
+                "mode": {
+                    "times": 30
+                },  # sufficiently high enough such that the time effect of backoff is noticeable
                 "data": {
                     "failCommands": ["commitTransaction"],
                     "errorCode": 24,
@@ -629,16 +633,11 @@ def test_transaction_backoff(self):
         def callback(session):
             coll.insert_one({}, session=session)
 
-        total_backoff = 0
         with self.client.start_session() as s:
             s.with_transaction(callback)
-            self.assertEqual(len(s._transaction_retry_backoffs), 3)
-            for backoff in s._transaction_retry_backoffs:
-                self.assertGreater(backoff, 0)
-                total_backoff += backoff
 
         end = time.monotonic()
-        self.assertGreaterEqual(end - start, total_backoff)
+        self.assertGreaterEqual(end - start, 1.25)  # 1 second
 
 
 class TestOptionsInsideTransactionProse(TransactionsBase):