PYTHON-4758 - Only emit warnings for unclosed clients after opening (#1856)

NoahStapp · web-flow · commit 9b9cf7336828 · 2024-09-12T16:19:05.000-04:00
diff --git a/pymongo/asynchronous/mongo_client.py b/pymongo/asynchronous/mongo_client.py
@@ -1185,7 +1185,7 @@ def __getitem__(self, name: str) -> database.AsyncDatabase[_DocumentType]:
     def __del__(self) -> None:
         """Check that this AsyncMongoClient has been closed and issue a warning if not."""
         try:
-            if not self._closed:
+            if self._opened and not self._closed:
                 warnings.warn(
                     (
                         f"Unclosed {type(self).__name__} opened at:\n{self._topology_settings._stack}"
diff --git a/pymongo/synchronous/mongo_client.py b/pymongo/synchronous/mongo_client.py
@@ -1185,7 +1185,7 @@ def __getitem__(self, name: str) -> database.Database[_DocumentType]:
     def __del__(self) -> None:
         """Check that this MongoClient has been closed and issue a warning if not."""
         try:
-            if not self._closed:
+            if self._opened and not self._closed:
                 warnings.warn(
                     (
                         f"Unclosed {type(self).__name__} opened at:\n{self._topology_settings._stack}"

Original file line number	Diff line number	Diff line change
`@@ -1185,7 +1185,7 @@ def __getitem__(self, name: str) -> database.AsyncDatabase[_DocumentType]:`
`1185`	`1185`	`def __del__(self) -> None:`
`1186`	`1186`	`"""Check that this AsyncMongoClient has been closed and issue a warning if not."""`
`1187`	`1187`	`try:`
`1188`		`- if not self._closed:`
	`1188`	`+ if self._opened and not self._closed:`
`1189`	`1189`	`warnings.warn(`
`1190`	`1190`	`(`
`1191`	`1191`	`f"Unclosed {type(self).__name__} opened at:\n{self._topology_settings._stack}"`