Remove unneeded _filter_servers and test

Author: NoahStapp

pymongo/asynchronous/topology.py

@@ -404,7 +404,6 @@ async def _select_server(
             operation_id,
             deprioritized_servers,
         )
-        servers = _filter_servers(servers, deprioritized_servers)
         if len(servers) == 1:
             return servers[0]
         server1, server2 = random.sample(servers, 2)
@@ -1129,16 +1128,3 @@ def _is_stale_server_description(current_sd: ServerDescription, new_sd: ServerDe
     if current_tv["processId"] != new_tv["processId"]:
         return False
     return current_tv["counter"] > new_tv["counter"]
-
-
-def _filter_servers(
-    candidates: list[Server], deprioritized_servers: Optional[list[Server]] = None
-) -> list[Server]:
-    """Filter out deprioritized servers from a list of server candidates."""
-    if not deprioritized_servers:
-        return candidates
-
-    filtered = [server for server in candidates if server not in deprioritized_servers]
-
-    # If not possible to pick a prioritized server, return the original list
-    return filtered or candidates

pymongo/synchronous/topology.py

@@ -404,7 +404,6 @@ def _select_server(
             operation_id,
             deprioritized_servers,
         )
-        servers = _filter_servers(servers, deprioritized_servers)
         if len(servers) == 1:
             return servers[0]
         server1, server2 = random.sample(servers, 2)
@@ -1127,16 +1126,3 @@ def _is_stale_server_description(current_sd: ServerDescription, new_sd: ServerDe
     if current_tv["processId"] != new_tv["processId"]:
         return False
     return current_tv["counter"] > new_tv["counter"]
-
-
-def _filter_servers(
-    candidates: list[Server], deprioritized_servers: Optional[list[Server]] = None
-) -> list[Server]:
-    """Filter out deprioritized servers from a list of server candidates."""
-    if not deprioritized_servers:
-        return candidates
-
-    filtered = [server for server in candidates if server not in deprioritized_servers]
-
-    # If not possible to pick a prioritized server, return the original list
-    return filtered or candidates

test/test_topology.py

@@ -733,23 +733,6 @@ def test_unexpected_load_balancer(self):
         self.assertNotIn(("a", 27017), t.description.server_descriptions())
         self.assertEqual(t.description.topology_type_name, "Unknown")
 
-    def test_filtered_server_selection(self):
-        s1 = Server(ServerDescription(("localhost", 27017)), pool=object(), monitor=object())  # type: ignore[arg-type]
-        s2 = Server(ServerDescription(("localhost2", 27017)), pool=object(), monitor=object())  # type: ignore[arg-type]
-        servers = [s1, s2]
-
-        result = _filter_servers(servers, deprioritized_servers=[s2])
-        self.assertEqual(result, [s1])
-
-        result = _filter_servers(servers, deprioritized_servers=[s1, s2])
-        self.assertEqual(result, servers)
-
-        result = _filter_servers(servers, deprioritized_servers=[])
-        self.assertEqual(result, servers)
-
-        result = _filter_servers(servers)
-        self.assertEqual(result, servers)
-
 
 def wait_for_primary(topology):
     """Wait for a Topology to discover a writable server.