Apply Dachary feedback 2

Author: cbullinger

generated-usage-examples/go/atlas-sdk-go/main.snippet.archive-collections.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"fmt"
 	"log"
-	"os"
 	"time"
 
 	"atlas-sdk-go/internal/archive"
@@ -21,8 +20,7 @@ func main() {
 		log.Printf("Warning: could not load %s file: %v", envFile, err)
 	}
 
-	configPath := os.Getenv("CONFIG_FILE")
-	secrets, cfg, err := config.LoadAll(configPath)
+	secrets, cfg, err := config.LoadAllFromEnv()
 	if err != nil {
 		log.Fatalf("Failed to load configuration %v", err)
 	}
@@ -51,25 +49,62 @@ func main() {
 
 	// Connect to each cluster and analyze collections for archiving
 	failedArchives := 0
+	skippedCandidates := 0
 	totalCandidates := 0
+
+	// Create archive options with custom settings
+	opts := archive.DefaultOptions()
+	opts.DefaultRetentionMultiplier = 2
+	opts.MinimumRetentionDays = 30
+	opts.EnableDataExpiration = true
+	opts.ArchiveSchedule = "DAILY"
+
 	for _, cluster := range clusters.GetResults() {
 		clusterName := cluster.GetName()
 		fmt.Printf("\n=== Analyzing cluster: %s ===", clusterName)
 
-		// Find collections suitable for archiving based on specific criteria.
-		// NOTE: The actual implementation of this function would involve more complex logic
-		// to determine which collections are eligible for archiving.
-		candidates := archive.CollectionsForArchiving(ctx, client, projectID, clusterName)
+		// Find collections suitable for archiving based on demo criteria.
+		// This simplified example first selects all collections with counts, and then filtering them.
+		// NOTE: In a real implementation, you would analyze collections based on size, age,
+		// access patterns, and other factors to determine candidates for archiving.
+		stats := archive.ListCollectionsWithCounts(ctx, client, projectID, clusterName)
+		candidates := make([]archive.Candidate, 0)
+		const docThreshold = 100000
+		for _, s := range stats {
+			// Skip internal databases
+			if s.DatabaseName == "admin" || s.DatabaseName == "local" || s.DatabaseName == "config" {
+				continue
+			}
+			// Demo criterion: collections with >= 100k documents
+			if s.EstimatedCount >= docThreshold {
+				candidates = append(candidates, archive.Candidate{
+					DatabaseName:    s.DatabaseName,
+					CollectionName:  s.CollectionName,
+					DateField:       "createdAt",
+					DateFormat:      "DATE",
+					RetentionDays:   90,
+					PartitionFields: []string{"createdAt"},
+				})
+			}
+		}
 		totalCandidates += len(candidates)
 		fmt.Printf("\nFound %d collections eligible for archiving in cluster %s\n",
 			len(candidates), clusterName)
 
 		// Configure online archive for each candidate collection
 		for _, candidate := range candidates {
+			// Pre-validate candidate before attempting configuration
+			if err := archive.ValidateCandidate(candidate, opts); err != nil {
+				fmt.Printf("- Skipping %s.%s: invalid candidate: %v\n",
+					candidate.DatabaseName, candidate.CollectionName, err)
+				skippedCandidates++
+				continue
+			}
+
 			fmt.Printf("- Configuring archive for %s.%s\n",
 				candidate.DatabaseName, candidate.CollectionName)
 
-			configureErr := archive.ConfigureOnlineArchive(ctx, client, projectID, clusterName, candidate)
+			configureErr := archive.ConfigureOnlineArchive(ctx, client, projectID, clusterName, candidate, opts)
 			if configureErr != nil {
 				fmt.Printf("  Failed to configure archive: %v\n", configureErr)
 				failedArchives++
@@ -81,8 +116,11 @@ func main() {
 		}
 	}
 
+	if skippedCandidates > 0 {
+		fmt.Printf("\nINFO: Skipped %d of %d candidates due to validation errors\n", skippedCandidates, totalCandidates)
+	}
 	if failedArchives > 0 {
-		fmt.Printf("\nWARNING: %d of %d archive configurations failed\n", failedArchives, totalCandidates)
+		fmt.Printf("WARNING: %d of %d archive configurations failed (excluding skipped)\n", failedArchives, totalCandidates-skippedCandidates)
 	}
 
 	fmt.Println("Archive analysis and configuration completed.")

generated-usage-examples/go/atlas-sdk-go/main.snippet.get-logs.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"fmt"
 	"log"
-	"os"
 
 	"atlas-sdk-go/internal/auth"
 	"atlas-sdk-go/internal/config"
@@ -22,8 +21,7 @@ func main() {
 		log.Printf("Warning: could not load %s file: %v", envFile, err)
 	}
 
-	configPath := os.Getenv("CONFIG_FILE")
-	secrets, cfg, err := config.LoadAll(configPath)
+	secrets, cfg, err := config.LoadAllFromEnv()
 	if err != nil {
 		log.Fatalf("Failed to load configuration %v", err)
 	}

generated-usage-examples/go/atlas-sdk-go/main.snippet.get-metrics-dev.go

@@ -6,7 +6,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"log"
-	"os"
 
 	"atlas-sdk-go/internal/auth"
 	"atlas-sdk-go/internal/config"
@@ -22,8 +21,7 @@ func main() {
 		log.Printf("Warning: could not load %s file: %v", envFile, err)
 	}
 
-	configPath := os.Getenv("CONFIG_FILE")
-	secrets, cfg, err := config.LoadAll(configPath)
+	secrets, cfg, err := config.LoadAllFromEnv()
 	if err != nil {
 		log.Fatalf("Failed to load configuration %v", err)
 	}

generated-usage-examples/go/atlas-sdk-go/main.snippet.get-metrics-prod.go

@@ -6,7 +6,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"log"
-	"os"
 
 	"atlas-sdk-go/internal/auth"
 	"atlas-sdk-go/internal/config"
@@ -23,8 +22,7 @@ func main() {
 		log.Printf("Warning: could not load %s file: %v", envFile, err)
 	}
 
-	configPath := os.Getenv("CONFIG_FILE")
-	secrets, cfg, err := config.LoadAll(configPath)
+	secrets, cfg, err := config.LoadAllFromEnv()
 	if err != nil {
 		log.Fatalf("Failed to load configuration %v", err)
 	}

generated-usage-examples/go/atlas-sdk-go/main.snippet.historical-billing.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"fmt"
 	"log"
-	"os"
 	"time"
 
 	"atlas-sdk-go/internal/auth"
@@ -23,8 +22,7 @@ func main() {
 	if err := godotenv.Load(envFile); err != nil {
 		log.Printf("Warning: could not load %s file: %v", envFile, err)
 	}
-	configPath := os.Getenv("CONFIG_PATH")
-	secrets, cfg, err := config.LoadAll(configPath)
+	secrets, cfg, err := config.LoadAllFromEnv()
 	if err != nil {
 		log.Fatalf("Failed to load configuration %v", err)
 	}

generated-usage-examples/go/atlas-sdk-go/main.snippet.line-items.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"fmt"
 	"log"
-	"os"
 
 	"github.com/joho/godotenv"
 	"go.mongodb.org/atlas-sdk/v20250219001/admin"
@@ -23,8 +22,7 @@ func main() {
 		log.Printf("Warning: could not load %s file: %v", envFile, err)
 	}
 
-	configPath := os.Getenv("CONFIG_FILE")
-	secrets, cfg, err := config.LoadAll(configPath)
+	secrets, cfg, err := config.LoadAllFromEnv()
 	if err != nil {
 		log.Fatalf("Failed to load configuration %v", err)
 	}

generated-usage-examples/go/atlas-sdk-go/main.snippet.linked-billing.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"fmt"
 	"log"
-	"os"
 
 	"atlas-sdk-go/internal/auth"
 	"atlas-sdk-go/internal/billing"
@@ -21,8 +20,7 @@ func main() {
 		log.Printf("Warning: could not load %s file: %v", envFile, err)
 	}
 
-	configPath := os.Getenv("CONFIG_FILE")
-	secrets, cfg, err := config.LoadAll(configPath)
+	secrets, cfg, err := config.LoadAllFromEnv()
 	if err != nil {
 		log.Fatalf("Failed to load configuration %v", err)
 	}

generated-usage-examples/go/atlas-sdk-go/project-copy/.gitignore

@@ -1,12 +1,10 @@
 # Secrets (keep example)
-tmp/.env
+.env
 !.env.example
-tmp/.env.development
 .env.production
-tmp/.env.test
 
-# config files (keep example)
-configs
+# Configs (keep example)
+configs/config.json
 !configs/config.example.json
 
 # temporary files

generated-usage-examples/go/atlas-sdk-go/project-copy/README.md

@@ -64,7 +64,7 @@ and improvements to existing code.
    MONGODB_ATLAS_SERVICE_ACCOUNT_ID=<your_service_account_id>
    MONGODB_ATLAS_SERVICE_ACCOUNT_SECRET=<your_service_account_secret>
    ATLAS_DOWNLOADS_DIR="tmp/atlas_downloads" # optional download directory
-   CONFIG_PATH="configs/config.development.json"
+   CONFIG_PATH="configs/config.development.json" # optional path to Atlas config file
    ```
    > **NOTE:** For production, use a secrets manager (e.g. HashiCorp Vault, AWS Secrets Manager) 
    > instead of environment variables. 

generated-usage-examples/go/atlas-sdk-go/project-copy/configs/config.example.json

@@ -0,0 +1,7 @@
+{
+  "MONGODB_ATLAS_BASE_URL": "https://cloud.mongodb.com",
+  "ATLAS_ORG_ID": "<your-organization-id>",
+  "ATLAS_PROJECT_ID": "<your-project-id>",
+  "ATLAS_CLUSTER_NAME": "<clusterName>",
+  "ATLAS_PROCESS_ID": "<clusterName-shard-00-00.hostSuffix.mongodb.net:port>"
+}