chore(e2e-tests): import from @mongosh/testing #2615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
the
no-title-validation
There was a problem hiding this comment.
Pull request overview
This PR refactors the e2e-tests package to import testing utilities from the @mongosh/testing package instead of using relative paths. The changes centralize testing utilities and improve the modularity of the codebase.
- Replaced relative imports from
../../testing/src/with imports from@mongosh/testing - Converted
startTestShellfrom a Mocha Context prototype extension to a standalone function - Added runtime safety checks for global test hooks availability
- Updated test configuration to remove the now-unnecessary test-shell-context require
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/testing/src/integration-testing-hooks.ts | Added runtime checks for global after hook availability and improved shared test server initialization |
| packages/e2e-tests/test/test-shell.ts | Updated import to use @mongosh/testing package |
| packages/e2e-tests/test/test-shell-context.ts | Converted startTestShell from prototype method to standalone function, removed Mocha Context module augmentation |
| packages/e2e-tests/test/test-shell-context.spec.ts | Updated to use new startTestShell function signature with explicit context parameter |
| packages/e2e-tests/test/repl-helpers.ts | Updated imports and removed unused getCertPath function |
| packages/e2e-tests/test/e2e.spec.ts | Updated all test files to use @mongosh/testing imports and new startTestShell function signature |
| packages/e2e-tests/test/e2e-tls.spec.ts | Updated imports and test calls to use new patterns |
| packages/e2e-tests/test/e2e-streams.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-snippet.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-snapshot.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-proxy.spec.ts | Updated imports, moved getCertPath to @mongosh/testing |
| packages/e2e-tests/test/e2e-oidc.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-fle.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-editor.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-direct.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-bson.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-banners.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-aws.spec.ts | Updated test calls to use new function signature |
| packages/e2e-tests/test/e2e-auth.spec.ts | Updated imports and test calls |
| packages/e2e-tests/test/e2e-analytics.spec.ts | Updated imports and test calls |
| packages/e2e-tests/package.json | Added @mongosh/testing dependency |
| packages/e2e-tests/.mocharc.json | Removed test-shell-context from required modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
approved these changes
Dec 8, 2025
Contributor
gagik
left a comment
gagik
left a comment
There was a problem hiding this comment.
Amazing, thank you for looking into this!
Contributor
|
Ah seems like e2e tests are still failing but still seems like the right direction. |
gagik
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first and last commits are mainly Search/Replace commits, so it may or may not be easier to review this commit-by-commit 🙂