-
Notifications
You must be signed in to change notification settings - Fork 246
feat(export-code): improve query to language discoverability COMPASS-8348 #7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(export-code): improve query to language discoverability COMPASS-8348 #7619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the discoverability of the "export query to language" feature by moving the export code button from the query bar to more prominent toolbar locations. The button is relocated to the CRUD documents toolbar and the aggregations pipeline settings area, making it more visible and accessible to users.
Key changes:
- Removed export-to-language button from the query bar component
- Added "Export Code" button to the CRUD documents toolbar
- Added "Export Data" and "Export Code" buttons to the aggregations pipeline toolbar
- Updated all associated tests to reflect the UI changes
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-query-bar/src/components/query-bar.tsx | Removed export-to-language button and related props/logic |
| packages/compass-query-bar/src/components/query-bar.spec.tsx | Removed tests for the removed export button |
| packages/compass-crud/src/stores/crud-store.ts | Added openQueryExportToLanguageDialog method |
| packages/compass-crud/src/components/document-list.tsx | Wired new export handler to toolbar |
| packages/compass-crud/src/components/crud-toolbar.tsx | Added Export Code button with responsive text hiding |
| packages/compass-crud/src/components/crud-toolbar.spec.tsx | Added onOpenExportToLanguage prop to tests |
| packages/compass-aggregations/src/plugin.tsx | Removed showExportButton prop |
| packages/compass-aggregations/src/plugin.spec.tsx | Updated test to remove export button assertion |
| packages/compass-aggregations/src/components/pipeline/pipeline.tsx | Removed showExportButton prop type |
| packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-settings/index.tsx | Added Export Data dropdown and Export Code button |
| packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-settings/index.spec.tsx | Updated tests for new buttons |
| packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-actions.tsx | Removed Export aggregation button |
| packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-actions.spec.tsx | Removed export button tests |
| packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/index.tsx | Removed showExportButton prop |
| packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/index.spec.tsx | Removed showExportButton prop from test |
| packages/compass-aggregations/src/components/pipeline-toolbar/index.tsx | Removed showExportButton prop |
| packages/compass-aggregations/src/components/pipeline-toolbar/index.spec.tsx | Removed showExportButton prop from tests |
| packages/compass-aggregations/src/components/aggregations/aggregations.spec.tsx | Removed showExportButton prop from test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-settings/index.tsx
Outdated
Show resolved
Hide resolved
… of github.com:mongodb-js/compass into COMPASS-8348/improve-query-to-language-discoverability
… of github.com:mongodb-js/compass into COMPASS-8348/improve-query-to-language-discoverability
…improve-query-to-language-discoverability
Description
Move position of "export code" button to improve discoverability.
Documents tab
Aggregations tab
Documents tab - short width
Agreggations tab - short width
Checklist
Motivation and Context
Open Questions
How do we update documentation after releasing these changes?
Dependents
Types of changes