Merge pull request #387 from mollie/386-testmode-without-data

Check if data exists, otherwise make it a dict

Author: Kees Hink

.github/workflows/tests.yaml

@@ -37,7 +37,9 @@ jobs:
         # urllib3, https://data.safetycli.com/v/77744/97c, only when using python 3.8. Consider upgrading.
         # setuptools, https://data.safetycli.com/v/76752/97c, only when using python 3.8. Consider upgrading.
         # regex, https://data.safetycli.com/v/78558/97c, only when using python 3.8. Consider upgrading.
-        run: python -m safety check --ignore 70612 --ignore 77744 --ignore 77745 --ignore 76752 --ignore 78558
+        # pip, https://data.safetycli.com/v/79883/97c, only when using python 3.8. Consider upgrading.
+        # authlib, https://data.safetycli.com/v/79756/97c, only when using python 3.8. Consider upgrading.
+        run: python -m safety check --ignore 70612 --ignore 77744 --ignore 77745 --ignore 76752 --ignore 78558 --ignore 79883 --ignore 79756
 
       - name: Verify code style
         run: python -m flake8 -v

mollie/api/client.py

@@ -201,6 +201,9 @@ def _get_testmode(self, data, params, http_method):
             if http_method == "GET":
                 params["testmode"] = params.get("testmode") or "true"
             elif not data or "testmode" not in data:
+                if not data:
+                    data = {}
+
                 data["testmode"] = params.get("testmode") or True
 
                 # Delete from the params since it's not a valid parameter when the request is not GET

tests/test_api_client.py

@@ -600,3 +600,9 @@ def test__get_testmode_sets_data_or_params_correctly(oauth_client, testmode, par
     oauth_client.testmode = testmode
     return_value = oauth_client._get_testmode({}, params, http_method)
     assert return_value == expected
+
+
+def test__get_testmode_does_not_crash_when_no_data(oauth_client):
+    oauth_client.testmode = True
+    return_value = oauth_client._get_testmode(None, {}, "POST")
+    assert return_value == ({"testmode": True}, {})