From 309ceb93b6e81a31368298c2e9686e2b28039ee7 Mon Sep 17 00:00:00 2001 From: Gustav Hansen Date: Wed, 6 May 2026 15:31:41 +0200 Subject: [PATCH] chore(managers,manifest,third-party-dts-extractor): drop `find-pkg` --- .changeset/replace-find-pkg-with-empathic.md | 7 +++++++ packages/managers/package.json | 2 +- packages/managers/src/PKGJsonManager.ts | 5 ++--- packages/managers/src/SharedManager.ts | 7 ++++--- packages/manifest/package.json | 3 +-- packages/third-party-dts-extractor/package.json | 2 +- .../src/ThirdPartyExtractor.ts | 14 ++++++++------ pnpm-lock.yaml | 7 ++----- 8 files changed, 26 insertions(+), 21 deletions(-) create mode 100644 .changeset/replace-find-pkg-with-empathic.md diff --git a/.changeset/replace-find-pkg-with-empathic.md b/.changeset/replace-find-pkg-with-empathic.md new file mode 100644 index 00000000000..fc5fd8c037c --- /dev/null +++ b/.changeset/replace-find-pkg-with-empathic.md @@ -0,0 +1,7 @@ +--- +'@module-federation/managers': patch +'@module-federation/third-party-dts-extractor': patch +'@module-federation/manifest': patch +--- + +chore: replace `find-pkg` with `empathic` (per [e18e replacements](https://e18e.dev/docs/replacements/find-pkg.html)). Removes unused `find-pkg` dependency from `@module-federation/manifest`. diff --git a/packages/managers/package.json b/packages/managers/package.json index 685d77b89a5..54d7d629e27 100644 --- a/packages/managers/package.json +++ b/packages/managers/package.json @@ -26,7 +26,7 @@ "types": "./dist/index.d.ts", "dependencies": { "@module-federation/sdk": "workspace:*", - "find-pkg": "2.0.0" + "empathic": "2.0.0" }, "devDependencies": { "webpack": "5.104.1" diff --git a/packages/managers/src/PKGJsonManager.ts b/packages/managers/src/PKGJsonManager.ts index a84812139dc..e57e62045ff 100644 --- a/packages/managers/src/PKGJsonManager.ts +++ b/packages/managers/src/PKGJsonManager.ts @@ -1,6 +1,5 @@ import path from 'path'; -// @ts-ignore this pkg miss types -import finder from 'find-pkg'; +import { up as findPkgUp } from 'empathic/package'; import fs from 'fs'; import { MFModuleType, logger } from '@module-federation/sdk'; @@ -24,7 +23,7 @@ export class PKGJsonManager { return pkg; } catch (_err) { try { - const pkg = finder.sync(root); + const pkg = findPkgUp({ cwd: root }) as unknown as Record; this._pkg = pkg; return pkg; } catch (err) { diff --git a/packages/managers/src/SharedManager.ts b/packages/managers/src/SharedManager.ts index 9dce6f0e194..d99852db240 100644 --- a/packages/managers/src/SharedManager.ts +++ b/packages/managers/src/SharedManager.ts @@ -1,5 +1,4 @@ -// @ts-ignore this pkg miss types -import findPkg from 'find-pkg'; +import { up as findPkgUp } from 'empathic/package'; import path from 'path'; import fs from 'fs'; import { @@ -70,7 +69,9 @@ class SharedManager extends BasicPluginOptionsManager", "license": "MIT", "dependencies": { - "find-pkg": "2.0.0", + "empathic": "2.0.0", "resolve": "1.22.8" }, "devDependencies": { diff --git a/packages/third-party-dts-extractor/src/ThirdPartyExtractor.ts b/packages/third-party-dts-extractor/src/ThirdPartyExtractor.ts index 17cfa1d55e5..d213de9b8e3 100644 --- a/packages/third-party-dts-extractor/src/ThirdPartyExtractor.ts +++ b/packages/third-party-dts-extractor/src/ThirdPartyExtractor.ts @@ -1,4 +1,4 @@ -import findPkg from 'find-pkg'; +import { up as findPkgUp } from 'empathic/package'; import { copyFile, lstat, mkdir, readdir } from 'fs/promises'; import { existsSync, readFileSync } from 'fs'; import path from 'path'; @@ -97,11 +97,13 @@ class ThirdPartyExtractor { return dir; } else { const typedPkgName = getTypedName(pkg.name); - const typedPkgJsonPath = findPkg.sync( - resolve.sync(`${typedPkgName}/package.json`, { - basedir: this.context, - }), - ) as string; + const typedPkgJsonPath = findPkgUp({ + cwd: path.dirname( + resolve.sync(`${typedPkgName}/package.json`, { + basedir: this.context, + }), + ), + }) as string; const typedDir = path.dirname(typedPkgJsonPath); readFileSync(typedPkgJsonPath, 'utf-8'); this.addPkgs(typedPkgName, typedDir); diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 6e13c22a0d9..bc4e1c384c6 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -3393,7 +3393,7 @@ importers: '@module-federation/sdk': specifier: workspace:* version: link:../sdk - find-pkg: + empathic: specifier: 2.0.0 version: 2.0.0 devDependencies: @@ -3412,9 +3412,6 @@ importers: '@module-federation/sdk': specifier: workspace:* version: link:../sdk - find-pkg: - specifier: 2.0.0 - version: 2.0.0 devDependencies: webpack: specifier: ^5.0.0 @@ -4082,7 +4079,7 @@ importers: packages/third-party-dts-extractor: dependencies: - find-pkg: + empathic: specifier: 2.0.0 version: 2.0.0 resolve: