fix: ignore invalid json messages only

Author: Sahar Shemesh

src/shared/stdio.test.ts

@@ -1,3 +1,4 @@
+import { ZodError } from 'zod/v4';
 import { JSONRPCMessage } from '../types.js';
 import { ReadBuffer } from './stdio.js';
 
@@ -34,9 +35,17 @@ test('should be reusable after clearing', () => {
     expect(readBuffer.readMessage()).toEqual(testMessage);
 });
 
-test('should override invalid messages and return null', () => {
+test('should override invalid json message and return null', () => {
     const readBuffer = new ReadBuffer();
 
     readBuffer.append(Buffer.from('invalid message\n'));
     expect(readBuffer.readMessage()).toBeNull();
 });
+
+test('should throw validation error on invalid JSON-RPC message', () => {
+    const readBuffer = new ReadBuffer();
+    const invalidJsonRpcMessage = '{"jsonrpc":"2.0","method":123}\n';
+    readBuffer.append(Buffer.from(invalidJsonRpcMessage));
+    expect(() => readBuffer.readMessage()).toThrowError(ZodError);
+});
+

src/shared/stdio.ts

@@ -35,8 +35,8 @@ export function deserializeMessage(line: string): JSONRPCMessage | null {
     try {
         return JSONRPCMessageSchema.parse(JSON.parse(line));
     } catch (error: unknown) {
-        // When Non JSONRPC message is received (parsing error or schema validation error), return null
-        if (error instanceof ZodError || error instanceof SyntaxError) {
+        // When non-JSON messages are received, we ignore them.
+        if (error instanceof SyntaxError) {
             return null;
         }
         throw error;