Skip to content

FR: Missing die test "suspicious_missing_die" #38

@jonasstein

Description

@jonasstein

Very often || die is missing behind echo to files or sed

For example:
echo '#!/bin/true' >share/genbuild.sh
should be
echo '#!/bin/true' >share/genbuild.sh || die

I think this will be part of a group of tests, which will never be 100% accurate, but remembers the maintainer to double check the line manually.

The following line lists all ebuilds with no die behind echo, while it is likely written to files there
qgrep -Nx "echo .* > " | grep -v die

Should we have a category suspicious for tests which will likely contain many false positives but are worth a verification?

We need the test for

  • echo
  • sed
  • rm
  • cp
  • mv

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions