Skip to content

Commit 9be1e13

Browse files
committed
Misc fixes
1. Fix linter issue in make_job_config 2. Fix typo in docker image creation script 3. Add importlib resources to ensure backwards compatibilty. Without that the tests seem to fail on ModuleNotFoundError.
1 parent c0d4087 commit 9be1e13

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

docker/build_docker_images.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ done
1717

1818
# Artifact repostiory
1919
if [ "$PROJECT" = "mlcommons-algoperf" ]; then
20-
ARTIFACT_REPO="europe-west-4-docker.pkg.dev/mlcommons-algoperf/algoperf-docker-repo"
20+
ARTIFACT_REPO="europe-west4-docker.pkg.dev/mlcommons-algoperf/algoperf-docker-repo"
2121
else
2222
ARTIFACT_REPO="us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo"
2323
fi

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ dependencies = [
4646
"clu==0.0.12",
4747
"matplotlib>=3.9.2",
4848
"tabulate==0.9.0",
49-
"wandb==0.21.0"
49+
"wandb==0.21.0",
50+
"importlib_resources"
5051
]
5152

5253
[build-system]

scoring/utils/slurm/make_job_config.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
'librispeech_deepspeech': {'dataset': 'librispeech'},
6868
'criteo1tb': {'dataset': 'criteo1tb'},
6969
'librispeech_conformer': {'dataset': 'librispeech'},
70-
'finewebedu_lm': {'dataset': 'fineweb_edu_10B'}
70+
'finewebedu_lm': {'dataset': 'fineweb_edu_10B'},
7171
}
7272

7373
RULESET_CONFIGS = {
@@ -92,7 +92,9 @@ def main(_):
9292

9393
num_tuning_trials = FLAGS.num_tuning_trials
9494
if num_tuning_trials is None:
95-
num_tuning_trials = RULESET_CONFIGS[FLAGS.tuning_ruleset]['num_tuning_trials']
95+
num_tuning_trials = RULESET_CONFIGS[FLAGS.tuning_ruleset][
96+
'num_tuning_trials'
97+
]
9698

9799
key = jax.random.PRNGKey(FLAGS.seed)
98100

0 commit comments

Comments
 (0)