VSCode perforce plugin throws error when trying to revert a file opened for edit.

[andersjj]

Describe the bug:
Getting an error when trying to revert a file that has been opened for edit

Expected behavior:
File is reverted and made non-writable

To Reproduce:
Select a file - right click select Perforce > Edit
Log shows
/var/www/html/user: p4 'edit' '/var/www/html/user/boot.html'
< //DEPOTNAME/boot.html#8 - opened for edit

Everything fine, but when trying to revert same file
/var/www/html/user: p4 'revert' '/var/www/html/user/boot.html'
ERROR: "'audit_log' validation failed: /var/www/html/user/boot.html - must create client 'perforce_server' to access local files.\n"

Works fine when I go to server and do following via CLI

p4 revert //DEPOTNAME/boot.html

The file is reverted and everything looks fine in P4V

Versions & Details:

• Perforce extension: 4.16.1
• VSCode version: 1.100.2
• Operating System: red-hat linux
• Perforce server details (if known):
• Are you using a multi-root workspace?: Yes/No

Additional context

Details

Relevant log entries shown above

[mjcrouch]

apologies, I have just realised my email has been partially down since mid-April so I haven't been receiving notifications for issues & PRs.

I'm not really sure what the issue might be exactly. This part of the error:

ERROR: "'audit_log' validation failed:

I think it means, your p4 server is set up with p4 triggers. It has one called "audit_log" which is performing validation, and that validation is failing on the revert. Assuming I'm right this is specific to your p4 server setup so I wouldn't be able to say why that is happening.

I'm thinking that something must be different between your command line environment and the vscode environment, since it works in one but not the other. Perhaps some environment variables that need to be set in vscode configuration, or something to do with the specific directory where you run the command compared to the vs code workspace?