fix(backend): devel backend detection + max height calc (#51)

* feat(build): clean dist script leaves browsers and gitignore

* feat(post-install): add script to set up local dx

* fix(backend): devel backend detection + max height calc

Author: gorillamoe

.envrc

@@ -1,2 +1,3 @@
 layout python
 layout node
+export PLAYWRIGHT_BROWSERS_PATH=./dist/.local-browsers

README.md

@@ -77,7 +77,7 @@ See: [lazy.nvim](https://github.com/folke/lazy.nvim)
 ```lua
 {
   'mistweaverco/snap.nvim',
-  version = 'v1.4.1',
+  version = 'v1.4.2',
   ---@type SnapUserConfig
   opts = {}
 },
@@ -93,7 +93,7 @@ See: [packer.nvim](https://github.com/wbthomason/packer.nvim)
 ```lua
 use {
   'mistweaverco/snap.nvim',
-  tag = 'v1.4.1',
+  tag = 'v1.4.2',
   config = function()
 
     ---@type SnapUserConfig
@@ -112,7 +112,7 @@ use {
 ```lua
 vim.pack.add({
   src = 'https://github.com/mistweaverco/snap.nvim.git',
-  version = 'v1.4.1',
+  version = 'v1.4.2',
 })
 ---@type SnapUserConfig
 local cfg = {}
@@ -244,7 +244,7 @@ This would then translate to the following `font_settings`:
 ```lua
 return {
   "mistweaverco/snap.nvim",
-  version = 'v1.4.1',
+  version = 'v1.4.2',
   ---@type SnapUserConfig
   opts = {
     template = "linux",
@@ -373,7 +373,7 @@ by running `bun install` in the plugin directory.
 ```lua
 {
   'mistweaverco/snap.nvim',
-  version = 'v1.4.1',
+  version = 'v1.4.2',
   opts = {
     timeout = 5000, -- Timeout for screenshot command in milliseconds
     log_level = "error", -- Log level for debugging (e.g., "trace", "debug", "info", "warn", "error", "off")

backend/bun/.prettierignore

@@ -0,0 +1,8 @@
+pnpm-lock.yaml
+package-lock.json
+yarn.lock
+templates/*.hbs
+dist/
+web/build/
+web/.svelte-kit/
+node_modules/

backend/bun/.prettierrc

@@ -0,0 +1,16 @@
+{
+  "useTabs": false,
+  "singleQuote": false,
+  "trailingComma": "all",
+  "printWidth": 120,
+  "plugins": ["prettier-plugin-svelte"],
+  "overrides": [
+    {
+      "files": "*.svelte",
+      "options": {
+        "parser": "svelte",
+        "useTabs": true
+      }
+    }
+  ]
+}

backend/bun/eslint.config.ts

@@ -0,0 +1,60 @@
+import { defineConfig, globalIgnores } from "eslint/config";
+import ts from "typescript-eslint";
+import svelte from "eslint-plugin-svelte";
+import svelteParser from "svelte-eslint-parser";
+import markdown from "@eslint/markdown";
+import css from "@eslint/css";
+import { tailwind4 } from "tailwind-csstree";
+import prettier from "eslint-config-prettier";
+
+export default defineConfig(
+  globalIgnores([".DS_Store", "dist/", "node_modules/", "web/build/", "web/.svelte-kit/", ".direnv/"]),
+  ...ts.configs.recommended,
+  {
+    files: ["backend/bun/**.ts", "eslint.config.ts"],
+    plugins: {
+      "@typescript-eslint": ts.plugin,
+    },
+    languageOptions: {
+      parser: ts.parser,
+      parserOptions: {
+        projectService: true,
+      },
+    },
+  },
+  {
+    files: ["web/**/*.svelte"],
+    plugins: { svelte },
+    languageOptions: {
+      parser: svelteParser,
+      parserOptions: {
+        parser: ts.parser,
+        extraFileExtensions: [".svelte"],
+      },
+    },
+    rules: {
+      ...svelte.configs["flat/recommended"][0].rules,
+    },
+  },
+  {
+    files: ["**/*.css"],
+    plugins: { css },
+    language: "css/css",
+    languageOptions: { customSyntax: tailwind4 },
+    rules: { "css/no-invalid-at-rules": "off" },
+  },
+  {
+    files: ["**/*.md"],
+    plugins: { markdown },
+    language: "markdown/gfm",
+    rules: {
+      "markdown/no-missing-label-refs": [
+        "error",
+        {
+          allowLabels: ["!NOTE", "!TIP", "!IMPORTANT", "!WARNING", "!CAUTION"],
+        },
+      ],
+    },
+  },
+  prettier,
+);

backend/bun/src/utils/browser.ts

@@ -16,69 +16,35 @@ function isExecutable(file: string): boolean {
   }
 }
 
+const EXE_NAMES =
+  process.platform === "win32"
+    ? ["chrome.exe", "chrome-headless-shell.exe"]
+    : process.platform === "darwin"
+      ? ["chrome-headless-shell", "Chromium"]
+      : ["chrome", "chrome-headless-shell"];
+
 /**
- * Finds Chromium executable in a given directory
- * @param playwrightDir - Directory containing chromium files
+ * Searches recursively for the Chromium executable in the given directory
+ * and its subdirectories.
+ * @param dir - Directory containing chromium files
  * @returns The path to the Chromium executable, or null if not found
  */
-function findChromiumInDirectory(playwrightDir: string): string | null {
-  if (!fs.existsSync(playwrightDir)) {
+function findChromiumInDirectory(dir: string): string | null {
+  if (!fs.existsSync(dir)) {
     return null;
   }
+  const entries = fs.readdirSync(dir, { withFileTypes: true });
+  for (const entry of entries) {
+    const fullPath = path.join(dir, entry.name);
 
-  // For bundled builds: executable is directly in playwright directory
-  // For cache (development): executable is in chromium-* or chromium_headless_shell* subdirectories
-
-  // Executable names to search for
-  const exeNames =
-    process.platform === "win32"
-      ? ["chrome.exe", "chrome-headless-shell.exe"]
-      : process.platform === "darwin"
-        ? ["chrome-headless-shell", "Chromium"]
-        : ["chrome", "chrome-headless-shell"];
-
-  // First, check directly in playwright directory (bundled builds)
-  for (const exeName of exeNames) {
-    const directPath = path.join(playwrightDir, exeName);
-    if (fs.existsSync(directPath) && isExecutable(directPath)) {
-      return directPath;
-    }
-  }
-
-  // Fall back to cache structure: look for chromium-* or chromium_headless_shell* directories
-  try {
-    const entries = fs.readdirSync(playwrightDir, { withFileTypes: true });
-    for (const entry of entries) {
-      if (
-        entry.isDirectory() &&
-        (entry.name.startsWith("chromium-") || entry.name.startsWith("chromium_headless_shell"))
-      ) {
-        const cacheDir = path.join(playwrightDir, entry.name);
-        // Recursively search in cache directory (max depth 2)
-        function search(dir: string, depth: number = 0): string | null {
-          if (depth > 2) return null;
-          try {
-            const dirEntries = fs.readdirSync(dir, { withFileTypes: true });
-            for (const dirEntry of dirEntries) {
-              const fullPath = path.join(dir, dirEntry.name);
-              if (dirEntry.isFile() && exeNames.includes(dirEntry.name) && isExecutable(fullPath)) {
-                return fullPath;
-              } else if (dirEntry.isDirectory() && !dirEntry.name.startsWith(".")) {
-                const found = search(fullPath, depth + 1);
-                if (found) return found;
-              }
-            }
-          } catch {
-            // Ignore errors
-          }
-          return null;
-        }
-        const found = search(cacheDir);
-        if (found) return found;
+    if (entry.isFile()) {
+      if (EXE_NAMES.includes(entry.name) && isExecutable(fullPath)) {
+        return fullPath;
       }
+    } else if (entry.isDirectory()) {
+      const found = findChromiumInDirectory(fullPath);
+      if (found) return found;
     }
-  } catch {
-    // Ignore errors
   }
 
   return null;
@@ -104,8 +70,8 @@ export function resolveChromiumExecutable(): string {
     return bundledExecutable;
   }
 
-  // Fall back to Playwright cache directory (development mode)
-  const cacheDir = path.join(os.homedir(), ".cache", "ms-playwright");
+  // Development mode
+  const cacheDir = path.join(process.cwd(), "dist", ".local-browsers");
   const cacheExecutable = findChromiumInDirectory(cacheDir);
   if (cacheExecutable) {
     return cacheExecutable;

backend/bun/src/utils/htmlToImage.ts

@@ -43,9 +43,7 @@ async function loadPlaywright() {
     return playwright.chromium;
   } catch (error) {
     throw new Error(
-      `Failed to load playwright-core: ${
-        error instanceof Error ? error.message : String(error)
-      }. ` +
+      `Failed to load playwright-core: ${error instanceof Error ? error.message : String(error)}. ` +
         "Make sure playwright-core is installed or bundled with the application in node_modules/playwright-core.",
     );
   }
@@ -56,9 +54,7 @@ async function loadPlaywright() {
  * @param options - Configuration options for the image generation
  * @returns Buffer containing the image data
  */
-export async function htmlToImage(
-  options: HtmlToImageOptions,
-): Promise<Buffer> {
+export async function htmlToImage(options: HtmlToImageOptions): Promise<Buffer> {
   const {
     html,
     output,
@@ -75,12 +71,7 @@ export async function htmlToImage(
   // Launch browser with appropriate settings
   const launchOptions: Parameters<typeof chromium.launch>[0] = {
     headless: true,
-    args: [
-      "--no-sandbox",
-      "--disable-setuid-sandbox",
-      "--disable-dev-shm-usage",
-      "--disable-gpu",
-    ],
+    args: ["--no-sandbox", "--disable-setuid-sandbox", "--disable-dev-shm-usage", "--disable-gpu"],
   };
 
   // If executable path is provided, use it explicitly
@@ -95,11 +86,7 @@ export async function htmlToImage(
 
     // Set content with HTML
     await page.setContent(html, {
-      waitUntil: waitUntil as
-        | "load"
-        | "domcontentloaded"
-        | "networkidle"
-        | "commit",
+      waitUntil: waitUntil as "load" | "domcontentloaded" | "networkidle" | "commit",
     });
 
     // Measure the actual rendered content width to respect max-width constraints
@@ -114,11 +101,7 @@ export async function htmlToImage(
 
       // Use body dimensions which respect max-width constraints
       const width = bodyRect.width;
-      const height = Math.max(
-        body.scrollHeight,
-        document.documentElement.scrollHeight,
-        bodyRect.height,
-      );
+      const height = bodyRect.top + bodyRect.height;
 
       return {
         width: Math.ceil(width),
@@ -156,9 +139,7 @@ export async function htmlToImage(
     });
 
     // Convert to Buffer if needed
-    const buffer = screenshotBuffer instanceof Buffer
-      ? screenshotBuffer
-      : Buffer.from(screenshotBuffer);
+    const buffer = screenshotBuffer instanceof Buffer ? screenshotBuffer : Buffer.from(screenshotBuffer);
 
     return buffer;
   } finally {

lua/snap/export.lua

@@ -21,11 +21,8 @@ local function check_backend_health(callback)
       if backend_bin_path == "" then
         error(conf.development_mode.backend .. " executable not found in PATH")
       end
-      cwd = payload.get_absolute_plugin_path("backend", conf.development_mode.backend)
-      if not vim.fn.isdirectory(cwd) then
-        error("Backend directory not found: " .. cwd)
-      end
-      system_args = { backend_bin_path, "run", "src/index.ts", "health" }
+      cwd = payload.get_absolute_plugin_path()
+      system_args = { backend_bin_path, "run", "backend/bun/src/index.ts", "health" }
     end
   end
 
@@ -86,12 +83,12 @@ local function install_backend(progress_callback, completion_callback)
       if backend_bin_path == "" then
         error(conf.development_mode.backend .. " executable not found in PATH")
       end
-      cwd = payload.get_absolute_plugin_path("backend", conf.development_mode.backend)
+      cwd = payload.get_absolute_plugin_path()
       if not vim.fn.isdirectory(cwd) then
         error("Backend directory not found: " .. cwd)
       end
       -- Use src/index.ts explicitly to ensure command line arguments are passed correctly
-      system_args = { backend_bin_path, "run", "src/index.ts", "install" }
+      system_args = { backend_bin_path, "run", "backend/bun/src/index.ts", "install" }
     end
   end
 
@@ -115,15 +112,17 @@ local function install_backend(progress_callback, completion_callback)
     debounce_timer = vim.fn.timer_start(150, function()
       if pending_progress and progress_callback then
         -- Only report 100% or "completed" once
-        if (pending_progress.progress == 100 or pending_progress.status == "completed") then
+        if pending_progress.progress == 100 or pending_progress.status == "completed" then
           if not progress_100_reported then
             progress_callback(pending_progress)
             progress_100_reported = true
           end
         else
           -- Only report if status or progress value changed
-          if pending_progress.status ~= last_progress_status or
-            (pending_progress.progress and pending_progress.progress ~= last_progress_value) then
+          if
+            pending_progress.status ~= last_progress_status
+            or (pending_progress.progress and pending_progress.progress ~= last_progress_value)
+          then
             progress_callback(pending_progress)
             last_progress_status = pending_progress.status
             last_progress_value = pending_progress.progress
@@ -195,7 +194,9 @@ local function install_backend(progress_callback, completion_callback)
       end
       -- Flush any pending progress immediately
       if pending_progress and progress_callback then
-        if not (pending_progress.progress == 100 or pending_progress.status == "completed") or not progress_100_reported then
+        if
+          not (pending_progress.progress == 100 or pending_progress.status == "completed") or not progress_100_reported
+        then
           progress_callback(pending_progress)
           if pending_progress.progress == 100 or pending_progress.status == "completed" then
             progress_100_reported = true
@@ -294,11 +295,11 @@ local function run_backend_export(opts, export_type, success_message)
           if backend_bin_path == "" then
             error(conf.development_mode.backend .. " executable not found in PATH")
           end
-          cwd = payload.get_absolute_plugin_path("backend", conf.development_mode.backend)
+          cwd = payload.get_absolute_plugin_path()
           if not vim.fn.isdirectory(cwd) then
             error("Backend directory not found: " .. cwd)
           end
-          system_args = { backend_bin_path, "run", "." }
+          system_args = { backend_bin_path, "run", "backend/bun/src/index.ts" }
         end
       end
 

lua/snap/globals/versions/backend.lua

@@ -1 +1 @@
-return "1.4.0"
+return "1.4.2"

lua/snap/globals/versions/plugin.lua

@@ -1 +1 @@
-return "1.4.1"
+return "1.4.2"