Fix bootstrapping functional test failure on Windows

Author: ImplOfAnImpl

chainstate/src/rpc/mod.rs

@@ -198,13 +198,13 @@ trait ChainstateRpc {
     #[method(name = "export_bootstrap_file")]
     async fn export_bootstrap_file(
         &self,
-        file_path: &std::path::Path,
+        file_path: std::path::PathBuf,
         include_stale_blocks: bool,
     ) -> RpcResult<()>;
 
     /// Imports a bootstrap file's blocks to this node
     #[method(name = "import_bootstrap_file")]
-    async fn import_bootstrap_file(&self, file_path: &std::path::Path) -> RpcResult<()>;
+    async fn import_bootstrap_file(&self, file_path: std::path::PathBuf) -> RpcResult<()>;
 
     /// Return generic information about the chain, including the current best block, best block height and more.
     #[method(name = "info")]
@@ -516,18 +516,16 @@ impl ChainstateRpcServer for super::ChainstateHandle {
 
     async fn export_bootstrap_file(
         &self,
-        file_path: &std::path::Path,
+        file_path: std::path::PathBuf,
         include_stale_blocks: bool,
     ) -> RpcResult<()> {
-        let file_path = file_path.to_owned();
         rpc::handle_result(
             self.call(move |this| export_bootstrap_file(this, &file_path, include_stale_blocks))
                 .await,
         )
     }
 
-    async fn import_bootstrap_file(&self, file_path: &std::path::Path) -> RpcResult<()> {
-        let file_path = file_path.to_owned();
+    async fn import_bootstrap_file(&self, file_path: std::path::PathBuf) -> RpcResult<()> {
         rpc::handle_result(self.call_mut(move |this| import_bootstrap_file(this, &file_path)).await)
     }
 

rpc/description/src/value_hint.rs

@@ -181,7 +181,13 @@ impl_value_hint!({
     NonZeroIsize => VH::NONZERO_NUMBER;
     NonZeroUsize => VH::NONZERO_NUMBER;
     String => VH::STRING;
-    std::path::Path => VH::STRING;
+    // Note: we implement `HasValueHint` for `PathBuf` but not for `Path`, because the latter
+    // won't work if used as a parameter and a native Windows path is passed to it, producing
+    // weird errors like:
+    //  jsonrpsee_core::proc_macros_support: Failed to parse JSON-RPC params as object: ErrorObject
+    //  { code: InvalidParams, message: "Invalid params", data: Some(RawValue("invalid type: string
+    //  \"C:\\\\aaa\\\\bbb\\\\file.txt\", expected a borrowed path at line 1 column xxx")) }
+    std::path::PathBuf => VH::STRING;
     std::net::SocketAddr => VH::STRING;
     std::net::IpAddr => VH::STRING;
     std::net::Ipv4Addr => VH::STRING;