Linting setup and fixes

Author: mindsocket

.claude/hooks/lint-and-test.sh

@@ -0,0 +1,28 @@
+#!/bin/bash
+# Run linting and tests before task stop
+# Exit code 1: warning (show results but don't block stop)
+# Exit code 0: all checks passed
+
+echo "🔍 Running pre-stop checks..." >&2
+
+# Track overall status
+STATUS=0
+
+echo "→ Linting (with auto-fix)..." >&2
+if ! bun run lint:fix --error-on-warnings --reporter=summary; then
+    STATUS=1
+fi
+
+echo "" >&2
+echo "→ Running tests..." >&2
+if ! bun test --only-failures; then
+    STATUS=1
+fi
+
+if [ $STATUS -ne 0 ]; then
+    echo "⚠️ Checks failed. Review output above." >&2
+else
+    echo "✅ All checks passed!" >&2
+fi
+
+exit $STATUS

.claude/settings.json

@@ -0,0 +1,14 @@
+{
+  "hooks": {
+    "Stop": [
+      {
+        "hooks": [
+          {
+            "type": "command",
+            "command": "\"$CLAUDE_PROJECT_DIR\"/.claude/hooks/lint-and-test.sh"
+          }
+        ]
+      }
+    ]
+  }
+}

.github/workflows/test.yml

@@ -14,4 +14,5 @@ jobs:
         with:
           bun-version: latest
       - run: bun install --frozen-lockfile
+      - run: bun run lint
       - run: bun test

CLAUDE.md

@@ -4,28 +4,25 @@ Opportunity Solution Tree (OST) validation and diagram generation tooling.
 
 ## Development
 
-```bash
-bun run src/index.ts validate <space-or-dir>
-bun run src/index.ts diagram <space-or-dir>
-bun run src/index.ts template-sync <template-dir>
-```
-
+Get a list of commands: `bun run src/index.ts --help`
 Space aliases (e.g. `personal`, `politics`) are resolved via `config.json`.
 
 ## Project Context
 
-This project validates OST node markdown files against a JSON schema. Node types: `vision`, `mission`, `goal`, `opportunity`, `solution`, `dashboard`.
-
-As a convenience, directories can be registered as "space" aliases in `config.json`.
+This project validates OST node markdown files against a JSON schema.
 
 ## Tooling
 
 - `gray-matter` - Parse YAML frontmatter from markdown
 - `ajv` - JSON Schema validation
 - `glob` - File discovery
 - `commander` - CLI interface
+- `bun test` - testing
 
 ## Key Files
 
 - `config.json` — Space registry (alias → absolute path)
 - `schema.json` — Entity type definitions and validation rules
+
+## Hooks
+A Stop hook runs linting, autoformatting and tests. If it reports issues related to change you made, address them.

biome.json

@@ -11,13 +11,16 @@
   "formatter": {
     "enabled": true,
     "indentStyle": "space",
-    "indentWidth": 2
+    "indentWidth": 2,
+    "lineWidth": 120
   },
   "linter": {
     "enabled": true,
     "rules": {
       "recommended": true,
-      "style": {}
+      "style": {
+      "noNonNullAssertion": "off"
+    }
     }
   },
   "javascript": {

package.json

@@ -10,7 +10,9 @@
   "scripts": {
     "validate": "bun run src/index.ts validate",
     "diagram": "bun run src/index.ts diagram",
-    "test": "bun test"
+    "test": "bun test",
+    "lint": "biome check src/ tests/",
+    "lint:fix": "biome check --write src/ tests/"
   },
   "devDependencies": {
     "@biomejs/biome": "^2.4.4",

src/config.ts

@@ -1,5 +1,5 @@
-import { readFileSync, writeFileSync, existsSync } from 'fs';
-import { join } from 'path';
+import { existsSync, readFileSync, writeFileSync } from 'node:fs';
+import { join } from 'node:path';
 import Ajv from 'ajv';
 
 const CONFIG_SCHEMA = {
@@ -63,13 +63,13 @@ export function loadConfig(): Config {
 
 /** Resolve alias-or-path to a filesystem path. Falls through if not an alias. */
 export function resolveSpacePath(aliasOrPath: string, config: Config): string {
-  const space = config.spaces.find(s => s.alias === aliasOrPath);
+  const space = config.spaces.find((s) => s.alias === aliasOrPath);
   return space ? space.path : aliasOrPath;
 }
 
 /** Get the full space config entry by alias. Throws if not found. */
 export function getSpaceConfig(alias: string, config: Config): SpaceConfig {
-  const space = config.spaces.find(s => s.alias === alias);
+  const space = config.spaces.find((s) => s.alias === alias);
   if (!space) {
     throw new Error(`Unknown space config: "${alias}". Check config.json.`);
   }
@@ -96,5 +96,5 @@ export function updateSpaceField(alias: string, field: keyof SpaceConfig, value:
   const config = loadConfig();
   const space = getSpaceConfig(alias, config);
   space[field] = value;
-  writeFileSync(configPath(), JSON.stringify(config, null, 2) + '\n');
+  writeFileSync(configPath(), `${JSON.stringify(config, null, 2)}\n`);
 }

src/diagram.ts

@@ -1,7 +1,7 @@
-import { readFileSync, writeFileSync, statSync } from 'fs';
+import { readFileSync, statSync, writeFileSync } from 'node:fs';
 import Ajv from 'ajv';
-import { readSpace } from './read-space.js';
 import { readOstPage } from './read-ost-page.js';
+import { readSpace } from './read-space.js';
 import type { OstNode } from './types.js';
 
 interface DiagramNode {
@@ -42,9 +42,7 @@ export async function diagram(path: string, options: { schema: string; output?:
       continue;
     }
 
-    const parent = node.data.parent
-      ? parseWikilink(node.data.parent as string)
-      : undefined;
+    const parent = node.data.parent ? parseWikilink(node.data.parent as string) : undefined;
 
     nodes.push({
       id: node.data.title as string,
@@ -65,8 +63,8 @@ export async function diagram(path: string, options: { schema: string; output?:
   let mmd = 'graph TD\n';
 
   // Find roots (no parent) and orphans
-  const roots = nodes.filter(n => !n.parent);
-  const orphans = roots.filter(n => n.type !== 'vision');
+  const roots = nodes.filter((n) => !n.parent);
+  const orphans = roots.filter((n) => n.type !== 'vision');
 
   // Add styling
   mmd += '  classDef vision fill:#ff9999,stroke:#ff0000,stroke-width:2px\n';
@@ -125,6 +123,6 @@ export async function diagram(path: string, options: { schema: string; output?:
   }
   if (invalid.length > 0) {
     console.error(`   Invalid (skipped): ${invalid.length}`);
-    invalid.forEach(f => console.error(`      ${f}`));
+    for (const f of invalid) console.error(`      ${f}`);
   }
 }

src/dump.ts

@@ -1,6 +1,6 @@
-import { statSync } from 'fs';
-import { readSpace } from './read-space.js';
+import { statSync } from 'node:fs';
 import { readOstPage } from './read-ost-page.js';
+import { readSpace } from './read-space.js';
 
 export async function dump(path: string) {
   if (statSync(path).isFile()) {

src/index.ts

@@ -1,12 +1,12 @@
 #!/usr/bin/env bun
 import { Command } from 'commander';
-import { validate } from './validate.js';
+import { loadConfig, resolveSchema, resolveSpacePath, resolveTemplateDir } from './config.js';
 import { diagram } from './diagram.js';
-import { show } from './show.js';
 import { dump } from './dump.js';
-import { templateSync } from './template-sync.js';
 import { miroSync } from './miro/sync.js';
-import { loadConfig, resolveSchema, resolveSpacePath, resolveTemplateDir } from './config.js';
+import { show } from './show.js';
+import { templateSync } from './template-sync.js';
+import { validate } from './validate.js';
 
 const program = new Command();
 
@@ -22,7 +22,10 @@ program
   .option('-s, --schema <path>', 'Path to JSON schema file')
   .action((spaceOrDir, options) => {
     const config = loadConfig();
-    validate(resolveSpacePath(spaceOrDir, config), { ...options, schema: resolveSchema(options.schema, config) });
+    validate(resolveSpacePath(spaceOrDir, config), {
+      ...options,
+      schema: resolveSchema(options.schema, config),
+    });
   });
 
 program
@@ -33,7 +36,10 @@ program
   .option('-s, --schema <path>', 'Path to JSON schema file')
   .action((spaceOrDir, options) => {
     const config = loadConfig();
-    diagram(resolveSpacePath(spaceOrDir, config), { ...options, schema: resolveSchema(options.schema, config) });
+    diagram(resolveSpacePath(spaceOrDir, config), {
+      ...options,
+      schema: resolveSchema(options.schema, config),
+    });
   });
 
 program
@@ -65,7 +71,10 @@ program
   .option('--dry-run', 'Preview changes without writing files')
   .action((templateDir, options) => {
     const config = loadConfig();
-    templateSync(resolveTemplateDir(templateDir, config), { ...options, schema: resolveSchema(options.schema, config) });
+    templateSync(resolveTemplateDir(templateDir, config), {
+      ...options,
+      schema: resolveSchema(options.schema, config),
+    });
   });
 
 program.parse();