🐛 take line height tolerance into account when evaluating fields (#127)

Author: ianardee

src/main/java/com/mindee/parsing/custom/lineitems/Anchor.java

@@ -8,12 +8,12 @@
 @Getter
 public final class Anchor {
   private final String name;
-  private final Double tolerance;
+  private final double tolerance;
 
   /**
    * Define an anchor with height tolerance.
    */
-  public Anchor(String name, Double tolerance) {
+  public Anchor(String name, double tolerance) {
     this.name = name;
     this.tolerance = tolerance;
   }
@@ -23,6 +23,6 @@ public Anchor(String name, Double tolerance) {
    */
   public Anchor(String name) {
     this.name = name;
-    this.tolerance = 0.001d;
+    this.tolerance = 0.01d;
   }
 }

src/main/java/com/mindee/parsing/custom/lineitems/LineItemsGenerator.java

@@ -1,5 +1,6 @@
 package com.mindee.parsing.custom.lineitems;
 
+import com.mindee.geometry.MinMax;
 import com.mindee.geometry.PolygonUtils;
 import com.mindee.parsing.custom.ListField;
 import com.mindee.parsing.custom.ListFieldValue;
@@ -20,42 +21,41 @@ private LineItemsGenerator() {
   /**
    * WARNING: This feature is experimental!
    * Results may not always work as intended.
-   * Don't use unless you know what you're doing ;-)
    */
   public static LineItems generate(
       List<String> fieldNames,
       Map<String, ListField> fields,
       Anchor anchor
   ) {
-
     Map<String, ListField> fieldsToTransformIntoLines = fields.entrySet()
         .stream()
         .filter(field -> fieldNames.contains(field.getKey()))
         .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
 
     List<Line> lines = populateLines(
         fieldsToTransformIntoLines,
-        new ArrayList<>(LineGenerator.prepareLines(fieldsToTransformIntoLines, anchor))
+        new ArrayList<>(LineGenerator.prepareLines(fieldsToTransformIntoLines, anchor)),
+        anchor.getTolerance()
     );
 
     return new LineItems(lines);
   }
 
   private static List<Line> populateLines(
       Map<String, ListField> fields,
-      List<Line> lines
+      List<Line> lines,
+      double heightLineTolerance
   ) {
-
     List<Line> populatedLines = new ArrayList<>();
 
     for (Line currentLine : lines) {
       for (Map.Entry<String, ListField> field : fields.entrySet()) {
         for (ListFieldValue listFieldValue : field.getValue().getValues()) {
-          double minYCurrentValue = PolygonUtils.getMinYCoordinate(listFieldValue.getPolygon());
+          MinMax minMaxY = PolygonUtils.getMinMaxY(listFieldValue.getPolygon().getCoordinates());
 
           if (
-              minYCurrentValue < currentLine.getBbox().getMaxY()
-              && minYCurrentValue >= currentLine.getBbox().getMinY()
+              Math.abs(minMaxY.getMax() - currentLine.getBbox().getMaxY()) <= heightLineTolerance
+              && Math.abs(minMaxY.getMin() - currentLine.getBbox().getMinY()) <= heightLineTolerance
           ) {
             currentLine.addField(field.getKey(), listFieldValue);
           }