MOBILEWEBVIEW-57: Add shouldOverrideUrlLoading for webviewclient#32
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the shouldOverrideUrlLoading callback to the WebView implementation, allowing consumers to intercept and handle URL loading events in the WebView. The change introduces a new interface method in WebViewEventListener with a default implementation that returns false, and implements the corresponding Android WebView callbacks.
Changes:
- Added
onShouldOverrideUrlLoadingmethod toWebViewEventListenerinterface with a default implementation returningfalse - Implemented both modern and deprecated
shouldOverrideUrlLoadingcallbacks in Android WebViewClient - Added cache mode setting to
LOAD_NO_CACHEinsetUserAgentSuffixmethod (though this appears redundant)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mindbox-common/src/commonMain/kotlin/cloud/mindbox/mobile_sdk/inapp/webview/WebViewInterfaces.kt | Adds new onShouldOverrideUrlLoading method to WebViewEventListener interface with default implementation |
| mindbox-common/src/androidMain/kotlin/cloud/mindbox/mobile_sdk/inapp/webview/WebViewAndroid.kt | Implements shouldOverrideUrlLoading callbacks in WebViewClient and adds duplicate cache mode setting |
Comments suppressed due to low confidence (1)
mindbox-common/src/androidMain/kotlin/cloud/mindbox/mobile_sdk/inapp/webview/WebViewAndroid.kt:62
- Setting cacheMode to LOAD_NO_CACHE here is redundant. The cache mode is already set to LOAD_NO_CACHE in the configureWebView method at line 106. This duplicate setting should be removed to avoid confusion and maintain consistency with the initialization pattern used for other WebView settings.
webView.settings.cacheMode = WebSettings.LOAD_NO_CACHE
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sergeysozinov
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILEWEBVIEW-57