Validate id doesn't check whether id is unique

[BigRoy]

Problem

The validate_id.py for a model publish checks whether all nodes at least have an id but they do not ensure all nodes in the instance have a unique id. To reproduce:

• Create a cube,
• save your scene (the cube now gets ids)
• duplicate the cube
• save the scene again (the duplicated cube doesn't get new ids, because it already has some)
• publish

This will publish without errors even though both cubes now cannot be uniquely identified because they share the same id.

[mottosso]

This is actually intentional, duplicates are assumed to be just that, duplicates and are given the same assignments, like shaders.

Have you encountered issues with this workflow?

[BigRoy]

Have you encountered issues with this workflow?

The tricky bit there is that it does not allow at all to have a different shader assigned to either of the two meshes which might make no sense to the lookdev artist.

I'm thinking of the situation, for example, where the model artist made a complex eye model for the left eye, duplicates that over for the right eye not thinking about the fact that the pipeline would think it is the exact same eye, a different shader could not be applied.