From 4789dab81a1a5f90ba3f4618f00793e401281268 Mon Sep 17 00:00:00 2001 From: Jadeon Date: Mon, 4 Mar 2019 10:21:08 -0800 Subject: [PATCH 1/2] Fix issue where JSDoc return was not generated if api route has no parameters --- src/gen/js/genOperations.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gen/js/genOperations.ts b/src/gen/js/genOperations.ts index 8b65cf7..2f48db8 100644 --- a/src/gen/js/genOperations.ts +++ b/src/gen/js/genOperations.ts @@ -68,8 +68,9 @@ function renderDocDescription(op: ApiOperation) { function renderDocParams(op: ApiOperation) { const params = op.parameters - if (!params.length) return [] - + if (!params.length) { + return [renderDocReturn(op)] + } const required = params.filter(param => param.required) const optional = params.filter(param => !param.required) From f7b066be7e58111f6467252313b7f01e8d0a6c0b Mon Sep 17 00:00:00 2001 From: Jadeon Sheppard Date: Mon, 12 Aug 2019 14:55:45 -0700 Subject: [PATCH 2/2] Removed "api.Response<>" --- src/gen/js/genOperations.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gen/js/genOperations.ts b/src/gen/js/genOperations.ts index 2f48db8..63e6fc6 100644 --- a/src/gen/js/genOperations.ts +++ b/src/gen/js/genOperations.ts @@ -153,7 +153,7 @@ function renderOptionalParamsSignature(op: ApiOperation, optional: ApiOperationP function renderReturnSignature(op: ApiOperation, options: ClientOptions): string { if (options.language !== 'ts') return '' const response = getBestResponse(op) - return `: Promise>` + return `: Promise<${getTSParamType(response)}>` } function getParamSignature(param: ApiOperationParam, options: ClientOptions): string[] {