Skip to content

Commit 0d33d3d

Browse files
committed
Revert #9c3031f3, virtual screen pointer size
Bad fix. `datalen` refers to content size and not size of address field. Needs a proper fix. Since this is only related to Host operation, perhaps avoid `writeDataBuffer`, `readStart` and `read` and instead use host-specific commands.
1 parent 798efcb commit 0d33d3d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

Tools/vs/screen.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ def processPacket(self, packet):
238238
data = list.read(datalen)
239239
self.setPixels(data)
240240
elif cmd == Code.writeDataBuffer:
241-
addr = list.read(datalen) # Discard pointer to buffer
241+
addr = list.read(4) # Discard pointer to buffer. TODO: This could be 32 or 64 bits
242242
data = self.packetQueue.get(timeout=0.5)
243243
if data is None:
244244
debug("Missing WRITE packet")
@@ -276,7 +276,7 @@ def processPacket(self, packet):
276276
elif cmd == Code.read or cmd == Code.readStart:
277277
if cmd == Code.readStart:
278278
self.addr.reset()
279-
list.read(4) # Discard pointer to buffer
279+
list.read(4) # Discard pointer to buffer. TODO: This could be 32 or 64 bits
280280
buffer = self.readPixels(datalen // BYTES_PER_PIXEL)
281281
# debug("READ(%u): %u" % (datalen, len(buffer)))
282282
self.server.send(buffer)

0 commit comments

Comments
 (0)