Merge pull request #70 from robertwesterlund/ignore_static_properties_in_value_converter

LiquidValueConverter ignores static properties. Fix for #69.

Author: mikebridge

Liquid.NET.Tests/Utils/LiquidValueConverterTests.cs

@@ -197,6 +197,21 @@ public void It_Should_Convert_An_Object()
             Assert.Equal(LiquidString.Create((String) testClass.ObjField1), objAsHash["objfield1"].Value);
         }
 
+        [Fact]
+        public void It_Should_Ignore_Static_Properties()
+        {
+            ClassWithStaticProperty.StaticField1 = "aaa";
+            var testClass = new ClassWithStaticProperty { Field1 = "bbb" };
+
+            var result = _converter.Convert(testClass);
+            Assert.True(result.HasValue);
+            var objAsHash = (LiquidHash)result.Value;
+
+            Assert.Equal(1, objAsHash.Keys.Count);
+            Assert.True(objAsHash.ContainsKey("field1"));
+            Assert.Equal(LiquidString.Create(testClass.Field1), objAsHash["field1"].Value);
+        }
+
         [Fact]
         public void It_Should_Convert_A_Nested_Object()
         {
@@ -310,5 +325,10 @@ public class ClassWithAttributes
 
         }
 
+        public class ClassWithStaticProperty
+        {
+            public String Field1 { get; set; }
+            public static String StaticField1 { get; set; }
+        }
     }
 }

Liquid.NET/src/Utils/LiquidValueConverter.cs

@@ -10,6 +10,8 @@ namespace Liquid.NET.Utils
 {
     public class LiquidValueConverter
     {
+        public static readonly BindingFlags PublicInstancePropertiesWithAGetter = BindingFlags.Public | BindingFlags.Instance | BindingFlags.GetProperty;
+
         public Option<ILiquidValue> Convert(Object obj)
         {
             if (ReferenceEquals(obj, null))
@@ -36,7 +38,7 @@ private Option<ILiquidValue> FromObject(Object obj)
         {
             var newHash = new LiquidHash();
             var kvps = obj.GetType()
-                .GetProperties()
+                .GetProperties(PublicInstancePropertiesWithAGetter)
                 .Where(property => !(property.GetCustomAttributes<LiquidIgnoreAttribute>().Any() 
                      || (property.GetCustomAttributes<LiquidIgnoreIfNullAttribute>().Any() 
                         && ReferenceEquals(property.GetGetMethod().Invoke(obj, null), null))))