From 086e50d001aa98f77112fe31cfb65dba7c0a9933 Mon Sep 17 00:00:00 2001 From: justusmattern27 Date: Thu, 3 Oct 2024 11:45:23 -0700 Subject: [PATCH 1/2] feat(player-react): let user modify onClick behavior --- packages/player-react/src/index.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/player-react/src/index.tsx b/packages/player-react/src/index.tsx index 90f949e06..309d7b94b 100644 --- a/packages/player-react/src/index.tsx +++ b/packages/player-react/src/index.tsx @@ -44,6 +44,7 @@ interface PlayerProps { onTimeUpdate?: (currentTime: number) => void; onPlayerReady?: (player: CorePlayer) => void; onPlayerResize?: (rect: DOMRectReadOnly) => void; + onClick?: () => void; } export function Player({ @@ -65,6 +66,7 @@ export function Player({ onTimeUpdate = () => {}, onPlayerReady = () => {}, onPlayerResize = () => {}, + onClick, }: PlayerProps) { const [playingState, setPlaying] = useState(playing); const [isMouseOver, setIsMouseOver] = useState(false); @@ -77,7 +79,7 @@ export function Player({ const wrapperRef = useRef(null); const lastRect = useRef(null); - const onClickHandler = controls ? () => setPlaying(prev => !prev) : undefined; + const onClickHandler = onClick || (controls ? () => setPlaying(prev => !prev) : undefined); /** * Sync the playing prop with the player's own state when it changes. From 35e8ed777c868460445200082bfc6ebf4e4208ff Mon Sep 17 00:00:00 2001 From: justusmattern27 Date: Thu, 3 Oct 2024 11:48:46 -0700 Subject: [PATCH 2/2] style: prettier --- packages/player-react/src/index.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/player-react/src/index.tsx b/packages/player-react/src/index.tsx index 309d7b94b..aaecdc6ed 100644 --- a/packages/player-react/src/index.tsx +++ b/packages/player-react/src/index.tsx @@ -79,7 +79,8 @@ export function Player({ const wrapperRef = useRef(null); const lastRect = useRef(null); - const onClickHandler = onClick || (controls ? () => setPlaying(prev => !prev) : undefined); + const onClickHandler = + onClick || (controls ? () => setPlaying(prev => !prev) : undefined); /** * Sync the playing prop with the player's own state when it changes.