Handle multi-root scenario

Author: anthonykim1

src/client/envExt/api.internal.ts

@@ -13,7 +13,7 @@ import {
     DidChangeEnvironmentEventArgs,
 } from './types';
 import { executeCommand } from '../common/vscodeApis/commandApis';
-import { getConfiguration } from '../common/vscodeApis/workspaceApis';
+import { getConfiguration, getWorkspaceFolders } from '../common/vscodeApis/workspaceApis';
 import { traceError, traceLog } from '../logging';
 import { Interpreters } from '../common/utils/localize';
 
@@ -26,7 +26,8 @@ export function isEnvExtensionInstalled(): boolean {
 /**
  * Returns true if the Python Environments extension is installed and not explicitly
  * disabled by the user. Mirrors the envs extension's own activation logic: it
- * deactivates only when `python.useEnvironmentsExtension` is explicitly set to false.
+ * deactivates only when `python.useEnvironmentsExtension` is explicitly set to false
+ * at the global, workspace, or workspace-folder level.
  */
 export function shouldEnvExtHandleActivation(): boolean {
     if (!isEnvExtensionInstalled()) {
@@ -37,6 +38,19 @@ export function shouldEnvExtHandleActivation(): boolean {
     if (inspection?.globalValue === false || inspection?.workspaceValue === false) {
         return false;
     }
+    // The envs extension also checks folder-scoped settings in multi-root workspaces.
+    // Any single folder with the setting set to false causes the envs extension to
+    // deactivate entirely (window-wide), so we must mirror that here.
+    const workspaceFolders = getWorkspaceFolders();
+    if (workspaceFolders) {
+        for (const folder of workspaceFolders) {
+            const folderConfig = getConfiguration('python', folder.uri);
+            const folderInspection = folderConfig.inspect<boolean>('useEnvironmentsExtension');
+            if (folderInspection?.workspaceFolderValue === false) {
+                return false;
+            }
+        }
+    }
     return true;
 }
 

src/test/common/terminals/activator/index.unit.test.ts

@@ -6,7 +6,7 @@
 import { assert } from 'chai';
 import * as sinon from 'sinon';
 import * as TypeMoq from 'typemoq';
-import { Terminal } from 'vscode';
+import { Terminal, Uri } from 'vscode';
 import { TerminalActivator } from '../../../../client/common/terminal/activator';
 import {
     ITerminalActivationHandler,
@@ -140,10 +140,13 @@ suite('Terminal Activator', () => {
 suite('shouldEnvExtHandleActivation', () => {
     let getExtensionStub: sinon.SinonStub;
     let getConfigurationStub: sinon.SinonStub;
+    let getWorkspaceFoldersStub: sinon.SinonStub;
 
     setup(() => {
         getExtensionStub = sinon.stub(extensionsApi, 'getExtension');
         getConfigurationStub = sinon.stub(workspaceApis, 'getConfiguration');
+        getWorkspaceFoldersStub = sinon.stub(workspaceApis, 'getWorkspaceFolders');
+        getWorkspaceFoldersStub.returns(undefined);
     });
 
     teardown(() => {
@@ -186,4 +189,21 @@ suite('shouldEnvExtHandleActivation', () => {
         });
         assert.strictEqual(extapi.shouldEnvExtHandleActivation(), true);
     });
+
+    test('Returns false when a workspace folder has workspaceFolderValue set to false', () => {
+        getExtensionStub.returns({ id: extapi.ENVS_EXTENSION_ID });
+        const folderUri = Uri.parse('file:///workspace/folder1');
+        getWorkspaceFoldersStub.returns([{ uri: folderUri, name: 'folder1', index: 0 }]);
+        getConfigurationStub.callsFake((_section: string, scope?: Uri) => {
+            if (scope) {
+                return {
+                    inspect: () => ({ workspaceFolderValue: false }),
+                };
+            }
+            return {
+                inspect: () => ({ globalValue: undefined, workspaceValue: undefined }),
+            };
+        });
+        assert.strictEqual(extapi.shouldEnvExtHandleActivation(), false);
+    });
 });