Don't re-run pytest when an exception in a test occurs (#25588)

The general `except` around the pytest run was causing tests to run
twice if the exception handling of pytest is disabled. From the comment
in the code it seems the exception handling is only there for when
reading the test IDs break, so it shouldn't be required around the
pytest main call.

Disabling the exception handling can be practical for debugging tests,
as this starts up the python debugger within vscode. Currently however,
this requires manually patching the run_pytest_script.py, which needs to
be re-done every vscode update.

fixes: #25656

Co-authored-by: Eleanor Boyd <26030610+eleanorjboyd@users.noreply.github.com>

Author: apuly

python_files/vscode_pytest/run_pytest_script.py

@@ -55,12 +55,13 @@ def run_pytest(args):
         try:
             # Read the test ids from the file and run pytest.
             ids = ids_path.read_text(encoding="utf-8").splitlines()
-            arg_array = ["-p", "vscode_pytest", *args, *ids]
-            print("Running pytest with args: " + str(arg_array))
-            pytest.main(arg_array)
         except Exception as e:
             print("Error[vscode-pytest]: unable to read testIds from temp file" + str(e))
             run_pytest(args)
+        else:
+            arg_array = ["-p", "vscode_pytest", *args, *ids]
+            print("Running pytest with args: " + str(arg_array))
+            pytest.main(arg_array)
         finally:
             # Delete the test ids temp file.
             try: