[Bug] parseCompilerArgs.bat fails if argument contains a space

[thefasquelle]

Brief Issue Summary

I have a makefile with this line :
-D'LFS_ASSERT(test)'='do { if(!(test)) {return -1;} } while(0)' \

The makefile works and makefile-tools is able to parse it and run make tasks.

But when configuring cpptools to use makefile-tools as a configuration provider, parseCompilerArgs.bat fails :

Error running the compiler args parser script c:\Users\ep.t.fasquelle\.vscode\extensions\ms-vscode.makefile-tools-0.12.17\assets\parseCompilerArgs.bat for regions (   -mcpuDONT_USE_EQUAL_AS_SEPARATORtc37xx -mtc162 -save-tempsDONT_USE_EQUAL_AS_SEPARATORobj              -ffunction-sections -fdata-sections -mpragma-data-sections -mpragma-function-sections -fstrict-volatile-bitfields -fgcse -fgcse-sm -fgcse-lm -fgcse-after-reload -ffast-math -funswitch-loops -fpredictive-commoning -fipa-cp-clone -fpeel-loops -fmove-loop-invariants -funroll-loops -finline-is-always-inline -Wall -Wextra -Wundef -Wshadow -Wdouble-promotion -Werror-implicit-function-declaration -Wuninitialized -Wno-missing-field-initializers -Wno-type-limits -fno-strict-aliasing -fno-builtin -fno-common -O0 -g3 -iquote -maligned-data-sections -Wmissing-prototypes -1;} } while(0)' -c -o  obj/Dal.o ../../SDK/DAL/Dal.c): ' �tait inattendu.

The compiler args parser script 'c:\Users\ep.t.fasquelle\.vscode\extensions\ms-vscode.makefile-tools-0.12.17\assets\parseCompilerArgs.bat' failed with error code    -mcpuDONT_USE_EQUAL_AS_SEPARATORtc37xx -mtc162 -save-tempsDONT_USE_EQUAL_AS_SEPARATORobj              -ffunction-sections -fdata-sections -mpragma-data-sections -mpragma-function-sections -fstrict-volatile-bitfields -fgcse -fgcse-sm -fgcse-lm -fgcse-after-reload -ffast-math -funswitch-loops -fpredictive-commoning -fipa-cp-clone -fpeel-loops -fmove-loop-invariants -funroll-loops -finline-is-always-inline -Wall -Wextra -Wundef -Wshadow -Wdouble-promotion -Werror-implicit-function-declaration -Wuninitialized -Wno-missing-field-initializers -Wno-type-limits -fno-strict-aliasing -fno-builtin -fno-common -O0 -g3 -iquote -maligned-data-sections -Wmissing-prototypes -1;} } while(0)' -c -o  obj/Dal.o ../../SDK/DAL/Dal.c for regions (undefined)
Sending configuration for file c:\Users\ep.t.fasquelle\Documents\dev\<censored>\SDK\DAL\Dal.c -----------------------------------

(I think ' �tait inattendu should be ' was unexpected here in English)

Debug Log

I believe the above should suffice and I would prefer not spend time sanitizing this very long output.
If you believe you really need the information from debug log I will do it.

Additional Information

No response

[yanghhhhhhh]

Hi @thefasquelle, thank you for reporting this issue. In order for us to investigate this further, could you please provide a sample project and repro steps to us that can reproduce this issue? Thanks.

[thefasquelle]

here is a small example makefile-tools_bug_repro.zip

It expects to have make (and other unix tools) in C:/msys64/usr/bin and gcc in C:/msys64/ucrt64/bin.
You can modify the paths if needed, or remove them entirely if you have make and gcc in your $ENV:PATH.

• If DEFINES := -D'MY_ASSERT(test)'='do { if(!(test)) {return -1;} } while(0)' in the Makefile is commented out, no issue is reported by any tool.
• If the line is not commented out
  • makefile-tools reports failure of arg parser script.
  • cpptools falls back to cl.exe instead of using gcc and reports command-line error: invalid macro definition: 'MY_ASSERT(test)'='do.
  • IntelliSense says MY_ASSERT(test) expands to 1.

[yanghhhhhhh]

@thefasquelle Thank you for your reply. We tried to reproduce this issue in the sample project, but it seems we were unable to reproduce this issue. If we missed something, please let us know. In order for us to investigate this further, could you please provide the detailed repro steps to us? Thanks.

[thefasquelle]

Simply extracting the zip and opening it shows the error on my computer.
Not on video but F1 > Makefile: Configure is the same.

makefile-tools_bug_compressed.mp4

It seems there is also an issue on your side because according to intellisense, MY_ASSERT(test) will return 17 which is the value returned by the definition in main.c. If it took the definition in Makefile, it would return -1

[yanghhhhhhh]

@thefasquelle thank you for your reply.
Reproduced this issue on VS Code 1.105.0 + Makefile Tools v0.12.17 release version.

Repro Steps:

1. Download the attached project and open it (makefile-tools_bug_repro.zip).
2. Run command "Makefile: Configure", observe the result.

Details please see following video:

FYI: @gcampbell-msft

[snehara99]

@yanghhhhhhh @thefasquelle I just tried to repro this issue with the lates zip file and couldn't. Can one of you check?

[yanghhhhhhh]

@snehara99 Thanks for checking this issue, we can reproduce this issue on VS Code 1.108.2 + Makefile Tools 0.12.17. Please refer to this video. If we missed something, please let us know. Thanks.