Client requests diagnostics after didClose

[DanielRosenwasser]

Similar to #1717.

If you open up an anonymous buffer, identify it as TypeScript, type some text, and save the file, you will occasionally end up with a log that looks like the attached file.

Basically the sequence is:

1. User saves an untitled buffer to someFile.ts
2. Client sends modification notifications:
   1. didOpen: someFile.ts
   2. didChange: someFile.ts
   3. didSave: someFile.ts
   4. didChange: Untitled file
   5. didClose: Untitled file
3. Client then sends
   1. diagnostics: someFile.ts (fine)
   2. diagnostics: Untitled file (minimally unnecessary, our LSP server responds with an error)

loggy.log

[dbaeumer]

@DanielRosenwasser does the language server register for workspace diagnostic pull as well. I have code here that pulls a last time on document close: https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/common/diagnostic.ts#L436

I should ignore untitled documents since the server forgets them on close.

[dbaeumer]

PR to ignore untitled documents on close is here: #1772

[DanielRosenwasser]

does the language server register for workspace diagnostic pull as well

Yes, we register workspace.diagnostics.refreshSupport = true, so that's probably it. Thanks for the quick fix!