Skip to content

Commit ed1d610

Browse files
wenytang-msCopilot
andcommitted
test(e2e): use expectConfirmDialog for delete confirm + pin autotest >= 0.6.7
The original windowsUI failure on this PR (run 25473266463) showed delete-context-menu silently passing while the Delete command never fired, only surfacing 30s later via verify-deleted. Root cause: the lenient confirmDialog swallowed the missing dialog and the substring-only contextMenu matcher did not validate the click landed. vscjava/vscode-autotest 0.6.7 fixes both: contextMenuOnTreeItem now pre-selects, smart-matches the menu item, and verifies the menu dismisses; expectConfirmDialog throws when the dialog is absent. Changes here: - confirm-delete step uses expectConfirmDialog for fail-fast on missing dialog. The lenient confirmDialog is kept for the rename flow (handle-rename-dialog) where the dialog is optional depending on user settings. - Both UI workflows pin @vscjava/vscode-autotest@^0.6.7 so the new verb is guaranteed to be available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 546dfee commit ed1d610

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

.github/workflows/linuxUI.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
run: vsce package -o vscode-java-dependency.vsix
4949

5050
- name: Setup autotest
51-
run: npm install -g @vscjava/vscode-autotest
51+
run: npm install -g @vscjava/vscode-autotest@^0.6.7
5252

5353
- name: E2E Test (autotest)
5454
env:

.github/workflows/windowsUI.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
run: vsce package -o vscode-java-dependency.vsix
4646

4747
- name: Setup autotest
48-
run: npm install -g @vscjava/vscode-autotest
48+
run: npm install -g @vscjava/vscode-autotest@^0.6.7
4949

5050
- name: E2E Test (autotest)
5151
env:

test/e2e-plans/java-dep-file-operations.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,12 @@ steps:
196196
action: "contextMenu AppToDelete Delete"
197197
verify: "Delete confirmation triggered"
198198

199-
# VSCode shows a platform-specific confirmation dialog for delete
199+
# VSCode shows a platform-specific confirmation dialog for delete.
200+
# Use the strict variant: throw if the dialog is not present, so a
201+
# silently-failed delete-context-menu surfaces here rather than 30s later
202+
# at verify-deleted. Requires @vscjava/vscode-autotest >= 0.6.7.
200203
- id: "confirm-delete"
201-
action: "confirmDialog"
204+
action: "expectConfirmDialog"
202205

203206
- id: "wait-delete"
204207
action: "wait 3 seconds"

0 commit comments

Comments
 (0)