Commit ed1d610
test(e2e): use expectConfirmDialog for delete confirm + pin autotest >= 0.6.7
The original windowsUI failure on this PR (run 25473266463) showed delete-context-menu silently passing while the Delete command never fired, only surfacing 30s later via verify-deleted. Root cause: the lenient confirmDialog swallowed the missing dialog and the substring-only contextMenu matcher did not validate the click landed.
vscjava/vscode-autotest 0.6.7 fixes both: contextMenuOnTreeItem now pre-selects, smart-matches the menu item, and verifies the menu dismisses; expectConfirmDialog throws when the dialog is absent.
Changes here:
- confirm-delete step uses expectConfirmDialog for fail-fast on missing dialog. The lenient confirmDialog is kept for the rename flow (handle-rename-dialog) where the dialog is optional depending on user settings.
- Both UI workflows pin @vscjava/vscode-autotest@^0.6.7 so the new verb is guaranteed to be available.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 546dfee commit ed1d610
3 files changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
200 | 203 | | |
201 | | - | |
| 204 | + | |
202 | 205 | | |
203 | 206 | | |
204 | 207 | | |
| |||
0 commit comments