Skip to content

One question about TOGA's implementation in data/atlas_star_datagen.py #5

@ghost

Description

Hi,
There is a regular expression in "toga/data/atlas_star_datagen.py"(Line 7):

split_re = re.compile("\"<AssertPlaceHolder>\" ;[ }]*")

I think you use this regular expression to separate a test method and a focal method in ATLAS' dataset. If test methods have statements or any other tokens following the marker "<AssertPlaceHolder>", these test methods cannot be matched by this regular expression. I think the correct version of Line 7 in atlas_star_datagen.py should be:

split_re = re.compile("\"<AssertPlaceHolder>\" .*?;( })+")

Could you let me know at your earliest convenience whether the above is my misunderstanding?
Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions