SQL Server Linux: JavaExtension -> Reduce minimum SPEES execution time down from 5 seconds. (#50)

* updated JavaExtensionUtils::CleanupJvm() to be platform specific. Where Linux code nulls g_jvm instead of calling destroyJVM() which causes execution delay on SPEES for sql server linux

* Update build scripts for proper tarball creation and update cleanupjvm method to be split per platform

* remove jvmdestroy for quicker spees execution since process exit will shutdown jvm.

* update javaextensionutils to have platform specific shutdownvm() func which doesn't call destroy jvm on linux to improve spees execution.

* updated code comments and removed extra new lines.

* add newline to prevent change marker.

* updated comments to reflect new methods.

* revert shell script changes so that we don't need to change pipelines

* revert changes

* work item number tracking.

* updated condition to just set g_jvm to null for linux . Updated comment to clarify this scenario is linux only.

Author: seantleonard

language-extensions/java/include/JavaExtensionUtils.h

@@ -78,6 +78,10 @@ class JavaExtensionUtils
 	//
 	static fn_createJvm LoadJvm(const std::string &jvmPath);
 
+	// Cleans up the JVM instance
+	//
+	static void ShutdownJvm(JavaVM *jvm);
+
 	// Unloads the JVM library
 	//
 	static void UnloadJvm();

language-extensions/java/src/JavaExtensionUtils.cpp

@@ -296,22 +296,9 @@ JNIEnv* JavaExtensionUtils::CreateJvm()
 //
 void JavaExtensionUtils::CleanupJvm()
 {
-	// Destroy the JVM
+	// Call platform specific function to shutdown the JVM
 	//
-	if (g_jvm != nullptr)
-	{
-		int rc = g_jvm->DestroyJavaVM();
-		if (rc == 0)
-		{
-			g_jvm = nullptr;
-		}
-		else
-		{
-			string msg = "Failed to destroy JVM. JNI error code: " + to_string(rc) + ".";
-
-			LOG_ERROR(msg);
-		}
-	}
+	ShutdownJvm(g_jvm);
 
 	// Call platform specific function to unload JVM library
 	//

language-extensions/java/src/linux/JavaExtensionUtils_linux.cpp

@@ -163,6 +163,22 @@ JavaExtensionUtils::fn_createJvm JavaExtensionUtils::LoadJvm(const string& jvmPa
 	return reinterpret_cast<fn_createJvm>(dlsym(g_jvmLib, "JNI_CreateJavaVM"));
 }
 
+//----------------------------------------------------------------------------
+// Name: JavaExtensionUtils::ShutdownJvm
+//
+// Description:
+//  Cleans up JVM resources. When running on Linux, clean up operation
+//  doesn't call Invocation API function DestroyJavaVM() because 
+//  ExtHost process exit defers to OS for resource cleanup 
+//  and SPEES query doesn't hang.
+//  Follow up investigation tracked via work item: 3090980
+//
+void JavaExtensionUtils::ShutdownJvm(JavaVM *jvm)
+{
+	LOG("Cleaning up JVM");
+	jvm = nullptr;
+}
+
 //----------------------------------------------------------------------------
 // Name: JavaExtensionUtils::UnloadJvm
 //

language-extensions/java/src/windows/JavaExtensionUtils_win.cpp

@@ -147,6 +147,32 @@ JavaExtensionUtils::fn_createJvm JavaExtensionUtils::LoadJvm(const string& jvmPa
 	return reinterpret_cast<fn_createJvm>(GetProcAddress(g_jvmDll, "JNI_CreateJavaVM"));
 }
 
+//----------------------------------------------------------------------------
+// Name: JavaExtensionUtils::ShutdownJvm
+//
+// Description:
+//  Cleans up JVM resources by calling the Invocation API function: DestroyJavaVM.
+//
+void JavaExtensionUtils::ShutdownJvm(JavaVM *jvm)
+{
+	// Destroy the JVM
+	//
+	LOG("Shutting down JVM");
+	if (jvm != nullptr)
+	{
+		int rc = jvm->DestroyJavaVM();
+		if (rc == 0)
+		{
+			jvm = nullptr;
+		}
+		else
+		{
+			string msg = "Failed to destroy JVM. JNI error code: " + to_string(rc) + ".";
+			LOG_ERROR(msg);
+		}
+	}
+}
+
 //----------------------------------------------------------------------------
 // Name: JavaExtensionUtils::UnloadJvm
 //