From d774d91f2c8bbdb0e3bcb77b912d491c885cc54b Mon Sep 17 00:00:00 2001 From: willcoliveira Date: Wed, 25 Feb 2026 09:16:32 +0000 Subject: [PATCH] docs: fix deprecated Playwright API usage in running-code.md --- .../src/skill/references/running-code.md | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/packages/playwright/src/skill/references/running-code.md b/packages/playwright/src/skill/references/running-code.md index 7d6d22fd090a7..8b35e9a41daab 100644 --- a/packages/playwright/src/skill/references/running-code.md +++ b/packages/playwright/src/skill/references/running-code.md @@ -87,7 +87,7 @@ playwright-cli run-code "async page => { # Wait for specific element playwright-cli run-code "async page => { - await page.waitForSelector('.loading', { state: 'hidden' }); + await page.locator('.loading').waitFor({ state: 'hidden' }); }" # Wait for function to return true @@ -97,7 +97,7 @@ playwright-cli run-code "async page => { # Wait with timeout playwright-cli run-code "async page => { - await page.waitForSelector('.result', { timeout: 10000 }); + await page.locator('.result').waitFor({ timeout: 10000 }); }" ``` @@ -122,10 +122,9 @@ playwright-cli run-code "async page => { ```bash # Handle file download playwright-cli run-code "async page => { - const [download] = await Promise.all([ - page.waitForEvent('download'), - page.click('a.download-link') - ]); + const downloadPromise = page.waitForEvent('download'); + await page.getByRole('link', { name: 'Download' }).click(); + const download = await downloadPromise; await download.saveAs('./downloaded-file.pdf'); return download.suggestedFilename(); }" @@ -197,7 +196,7 @@ playwright-cli run-code "async page => { # Try-catch in run-code playwright-cli run-code "async page => { try { - await page.click('.maybe-missing', { timeout: 1000 }); + await page.getByRole('button', { name: 'Submit' }).click({ timeout: 1000 }); return 'clicked'; } catch (e) { return 'element not found'; @@ -211,9 +210,9 @@ playwright-cli run-code "async page => { # Login and save state playwright-cli run-code "async page => { await page.goto('https://example.com/login'); - await page.fill('input[name=email]', 'user@example.com'); - await page.fill('input[name=password]', 'secret'); - await page.click('button[type=submit]'); + await page.getByRole('textbox', { name: 'Email' }).fill('user@example.com'); + await page.getByRole('textbox', { name: 'Password' }).fill('secret'); + await page.getByRole('button', { name: 'Sign in' }).click(); await page.waitForURL('**/dashboard'); await page.context().storageState({ path: 'auth.json' }); return 'Login successful';