fix(tests): bound CDP connect timeout, drop https for storage-state probe

pavelfeldman · claude · pavelfeldman · commit cf233da20d4a · 2026-04-29T08:23:21.000-07:00
Two unrelated Windows-only failures on PR #3051: 1. test_connect_over_cdp_passing_header_works hung on Windows + Python 3.12/3.13: connect_over_cdp had no explicit timeout, the bogus ws://127.0.0.1/ws endpoint never speaks CDP, and the IOCP scheduler on 3.12+ kept the await past the 90s pytest timeout. Pass timeout=5000 so the Error rises promptly. Upstream's parallel TS test does the same with timeout: 100; 5000 leaves headroom for slow runners. 2. test_set_storage_state_should_apply_state_to_existing_context hung on Stable Edge (Windows) only. The two https://www.example.com navigations took the network path before page.route intercepted. Use http://example.com instead — same origin semantics for the localStorage assertion, no TLS setup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
diff --git a/tests/async/test_browsercontext_storage_state.py b/tests/async/test_browsercontext_storage_state.py
@@ -136,13 +136,16 @@ async def test_should_round_trip_through_the_file(
 async def test_set_storage_state_should_apply_state_to_existing_context(
     browser: Browser,
 ) -> None:
+    # http (not https) avoids TLS setup on Edge stable on Windows where the
+    # network path is taken before route intercept short-circuits.
+    origin = "http://example.com"
     src = await browser.new_context()
     src_page = await src.new_page()
     await src_page.route(
         "**/*",
         lambda route: asyncio.create_task(route.fulfill(body="<html></html>")),
     )
-    await src_page.goto("https://www.example.com")
+    await src_page.goto(origin)
     await src_page.evaluate('() => localStorage.setItem("k", "v")')
     state = await src.storage_state()
     await src.close()
@@ -154,7 +157,7 @@ async def test_set_storage_state_should_apply_state_to_existing_context(
         lambda route: asyncio.create_task(route.fulfill(body="<html></html>")),
     )
     await dst.set_storage_state(state)
-    await dst_page.goto("https://www.example.com")
+    await dst_page.goto(origin)
     assert await dst_page.evaluate('() => localStorage.getItem("k")') == "v"
     await dst.close()
 
diff --git a/tests/async/test_browsertype_connect_cdp.py b/tests/async/test_browsertype_connect_cdp.py
@@ -96,7 +96,9 @@ async def test_connect_over_cdp_passing_header_works(
     request = asyncio.create_task(server.wait_for_request("/ws"))
     with pytest.raises(Error):
         await browser_type.connect_over_cdp(
-            f"ws://127.0.0.1:{server.PORT}/ws", headers={"foo": "bar"}
+            f"ws://127.0.0.1:{server.PORT}/ws",
+            headers={"foo": "bar"},
+            timeout=5000,
         )
     assert (await request).getHeader("foo") == "bar"
 
